Adding the explicit notes is most gratefully appreciated.

Good work removing the root node from remove and trash operations.

However, please

• use node:is(RootNode) instead of comparing the name
• use a simple list iterator ipairs instead of an integer incrementing loop. That is the lua way.

Same applies for trash.

As per https://github.com/nvim-tree/nvim-tree.lua/pull/3268/changes#r2862129812

These lines are identical to those in fn(). Please extract a function. The signature can look something like:

---@class TrashPrompt
---@field prompt_input string
---@field items_short string[]
---@field items_long string[]

---@param prompt_select string
---@return TrashPrompt
local function trash_prompt(prompt_select)

We normally want to avoid making changes to unrelated code, however having duplicated in code overrides this.

Many thanks for the detail.

lualine agrees with this mode detection.

However, we should add the various select modes as well - some users like to use the mouse.

See https://github.com/nvim-lualine/lualine.nvim/blob/47f91c416daef12db467145e16bed5bbfe00add8/lua/lualine/utils/mode.lua

Good work putting filter_descendant_nodes in utils.

Please move similar to utils:

• is_visual_mode
• exit_visual_mode
• get_visual_nodes

This duplicates wrap_node. Please call that.

These are very difficult to read and do not match the style of the surrounding code i.e. one api interface mapped to one function/method.

Let's refactor this:

Single entry point for remove:

---@param node Node
local function remove_one_node(node)
  ---
end

---@param nodes Node[]
local function remove_many_nodes(nodes)
  ---
end

---@param node_or_nodes Node|Node[] single node when called in normal mode, multiple nodes in visual mode
function M.fn(node_or_nodes)
  if node_or_nodes:is(Node) then
    remove_one_node(node_or_nodes)
  else
    remove_many_nodes(node_or_nodes)
  end

We then map the api to this single entry point:

  api.fs.remove = wrap_node_or_visual(actions.fs.remove_file.fn)

Yes, this goes against what I said earlier about proxies, however this is the lesser of two evils.

We now have the problem of how to choose whether to filter descendents. Plan:

• The implementation chooses to do the filtering itself.
• wrap_node_or_visual always passes all visual nodes.
• remove/trash etc. call filter_descendant_nodes themselves.

This moves implementation details from the api to the implementation itself.

As per https://github.com/nvim-tree/nvim-tree.lua/pull/3268/changes#r2862232144

Passing a table of Node or a single Node to cut and copy has the added benefit of allowing us to resolve the multiple prompts

As per https://github.com/nvim-tree/nvim-tree.lua/pull/3268/changes#r2862232144