Skip to content

Conversation

@NotTheDr01ds
Copy link
Contributor

Deprecates the existing stdlib-candidate directories in nu_scripts since std-rfc has now transitioned to the main repo. Updates readme and renamed directories.

@fdncred
Copy link
Contributor

fdncred commented Feb 9, 2025

Thanks for working on this! LGTM

@fdncred fdncred merged commit 5869e0b into nushell:main Feb 9, 2025
1 check failed
@fdncred
Copy link
Contributor

fdncred commented Feb 11, 2025

Looks like CI may be broke because dependent files were removed.
https://github.com/nushell/nu_scripts/actions/runs/13265142451/job/37030612656?pr=1044

@hongquan
Copy link
Contributor

Included the fix for CI in #1044

@fdncred
Copy link
Contributor

fdncred commented Feb 13, 2025

I'm not sure removing all testing is the right course of action.

@hongquan
Copy link
Contributor

The fix is moved to #1046

fdncred pushed a commit that referenced this pull request Feb 14, 2025
stdlib-candidate was removed in #1042 but test script still refer on it.

The concensus is to
[remove](#1044 (comment))
the test case.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants