feat: highlight selected version#964
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
1 Skipped Deployment
|
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
📝 WalkthroughWalkthroughThe changes add an optional Suggested reviewers
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches🧪 Generate unit tests (beta)
Tip We've launched Issue Planner and it is currently in beta. Please try it out and share your feedback on Discord! Comment |
There was a problem hiding this comment.
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
app/components/Package/Versions.vue (1)
641-644:⚠️ Potential issue | 🟡 MinorRemove per-button focus-visible utility classes.
Project guidance requires button focus-visible styling to be handled globally; this inline utility should be dropped.
🔧 Suggested fix
- class="w-4 h-4 flex items-center justify-center text-fg-subtle hover:text-fg transition-colors shrink-0 focus-visible:outline-accent/70 rounded-sm" + class="w-4 h-4 flex items-center justify-center text-fg-subtle hover:text-fg transition-colors shrink-0 rounded-sm"Based on learnings: “focus-visible styling for buttons and selects is applied globally via main.css… Do not apply per-element inline utility classes like focus-visible:outline-accent/70.”
fixes: #924
Before:

After:
