Skip to content

refactor: prefer useTemplateRef #749

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
43081j merged 1 commit into from
Feb 2, 2026
Merged

refactor: prefer useTemplateRef #749

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion app/components/AppHeader.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ const showMobileMenu = shallowRef(false)
const route = useRoute()
const isMobile = useIsMobile()
const isSearchExpandedManually = shallowRef(false)
const searchBoxRef = shallowRef<{ focus: () => void } | null>(null)
const searchBoxRef = useTemplateRef('searchBoxRef')

// On search page, always show search expanded on mobile
const isOnHomePage = computed(() => route.name === 'index')
Expand Down
2 changes: 1 addition & 1 deletion app/components/Header/SearchBox.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,7 +80,7 @@ function handleSearchFocus() {
}

// Expose focus method for parent components
const inputRef = shallowRef<HTMLInputElement | null>(null)
const inputRef = useTemplateRef('inputRef')
function focus() {
inputRef.value?.focus()
}
Expand Down
2 changes: 1 addition & 1 deletion app/components/Modal.client.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ const props = defineProps<{
modalTitle: string
}>()

const dialogRef = ref<HTMLDialogElement>()
const dialogRef = useTemplateRef('dialogRef')

const modalTitleId = computed(() => {
const id = getCurrentInstance()?.attrs.id
Expand Down
2 changes: 1 addition & 1 deletion app/components/Package/ClaimPackageModal.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,7 +96,7 @@ async function handleClaim() {
}
}

const dialogRef = ref<HTMLDialogElement>()
const dialogRef = useTemplateRef('dialogRef')

function open() {
// Reset state and check availability each time modal is opened
Expand Down
Loading