chore: guard undefined values in uno-preset-rtl#696
Merged
Conversation
Part of the test cleanup. When we eventually type-check this, it'll fail right now as these are all `T | undefined`. Adding `!` since in all cases, we know it is not null.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
2 Skipped Deployments
|
Contributor
|
Personally I'm not a fan of non-null assertions. They give you a false sense of security should things ever go south and produce harder-to-debug errors than they need to be. Why not just add error handling and throw if something is unexpectedly missing? |
danielroe
changed the title
uno-preset-rtl
danielroe
approved these changes
Feb 2, 2026
taskylizard
pushed a commit
to taskylizard/npmx.dev
that referenced
this pull request
Feb 7, 2026
Co-authored-by: Daniel Roe <daniel@roe.dev>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of the test cleanup.
When we eventually type-check this, it'll fail right now as these are
all
T | undefined. Adding!since in all cases, we know it is notnull.