Skip to content

feat: increase max package compares to 10#2294

Merged
graphieros merged 4 commits intomainfrom
increase-max-number-of-packages-to-compare
Mar 27, 2026
Merged

feat: increase max package compares to 10#2294
graphieros merged 4 commits intomainfrom
increase-max-number-of-packages-to-compare

Conversation

@graphieros
Copy link
Copy Markdown
Contributor

@graphieros graphieros commented Mar 27, 2026

Resolves #2289

  • increase max comparisons to 10
  • refactor to refer to the same MAX_PACKAGE_SELECTION constant
  • do not use a fix height of line / sparkline container in compare page

@graphieros graphieros linked an issue Mar 27, 2026 that may be closed by this pull request
@vercel
Copy link
Copy Markdown

vercel bot commented Mar 27, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
npmx.dev Ready Ready Preview, Comment Mar 27, 2026 3:11pm
2 Skipped Deployments
Project Deployment Actions Updated (UTC)
docs.npmx.dev Ignored Ignored Preview Mar 27, 2026 3:11pm
npmx-lunaria Ignored Ignored Mar 27, 2026 3:11pm

Request Review

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Mar 27, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: b799a70f-ad7c-4fa6-95cc-8fcf86fde91f

📥 Commits

Reviewing files that changed from the base of the PR and between 4a18344 and ae88cc7.

📒 Files selected for processing (1)
  • test/nuxt/components/compare/PackageSelector.spec.ts
🚧 Files skipped from review as they are similar to previous changes (1)
  • test/nuxt/components/compare/PackageSelector.spec.ts

📝 Walkthrough

Walkthrough

The pull request increases the selectable package limit from 4 to 10 by updating MAX_PACKAGE_SELECTION in app/composables/usePackageSelection.ts and replacing local maxPackages usages with that constant across the compare flow. PackageSelector.vue now falls back to MAX_PACKAGE_SELECTION when props.max is unset. compare.vue uses the shared constant for parsing, slicing and the “no dependency” column logic. TrendsChart.vue template class binding for panel height was adjusted to omit fixed height when isSparklineLayout is true or the component is not in a modal.

Possibly related PRs

Suggested labels

front, needs review

Suggested reviewers

  • alexdln
  • serhalp
  • danielroe
🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description check ✅ Passed The PR description directly addresses the changeset, detailing the increase to 10 max comparisons, refactoring to use a constant, and removing fixed heights.
Linked Issues check ✅ Passed The PR successfully implements the core requirement of issue #2289 by increasing max package comparisons from 4 to 10, refactoring to use MAX_PACKAGE_SELECTION constant, and removing fixed height constraints.
Out of Scope Changes check ✅ Passed All changes are directly scoped to the requirements: increasing the package limit to 10, centralising the constant, and adjusting container heights for sparkline layout compatibility.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch increase-max-number-of-packages-to-compare

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1


ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 1a7f4891-3fce-43e3-b202-1c64eb851a3d

📥 Commits

Reviewing files that changed from the base of the PR and between e0874d3 and 4a18344.

📒 Files selected for processing (1)
  • test/nuxt/components/compare/PackageSelector.spec.ts

@codecov
Copy link
Copy Markdown

codecov bot commented Mar 27, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ All tests successful. No failed tests found.

📢 Thoughts on this report? Let us know!

@graphieros graphieros added this pull request to the merge queue Mar 27, 2026
Merged via the queue into main with commit 754c64c Mar 27, 2026
23 checks passed
@graphieros graphieros deleted the increase-max-number-of-packages-to-compare branch March 27, 2026 16:08
@github-actions github-actions bot mentioned this pull request Mar 27, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Increase max number of packages to compare

2 participants