Skip to content

fix(ui): skeleton design not aligned between states#2177

Merged
MatteoGabriele merged 3 commits intonpmx-dev:mainfrom
MatteoGabriele:fix/design-package-skeleton-sidebar
Mar 21, 2026
Merged

fix(ui): skeleton design not aligned between states#2177
MatteoGabriele merged 3 commits intonpmx-dev:mainfrom
MatteoGabriele:fix/design-package-skeleton-sidebar

Conversation

@MatteoGabriele
Copy link
Member

@MatteoGabriele MatteoGabriele commented Mar 21, 2026

🔗 Linked issue

see #2170 (comment)

🧭 Context

The skeleton design is misaligned between the two states: it still includes a sticky header and a scroll area.

📚 Description

Aligned skeleton design with the loaded state.

Notes: The small remaining content shift is caused by the button height not aligning with the real button, and this has been fixed in a PR that addresses header buttons. #2170

before

Screen.Recording.2026-03-21.at.12.21.30.mov

after

Screen.Recording.2026-03-21.at.12.21.53.mov

@vercel
Copy link

vercel bot commented Mar 21, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
npmx.dev Ready Ready Preview, Comment Mar 21, 2026 3:05pm
2 Skipped Deployments
Project Deployment Actions Updated (UTC)
docs.npmx.dev Ignored Ignored Preview Mar 21, 2026 3:05pm
npmx-lunaria Ignored Ignored Mar 21, 2026 3:05pm

Request Review

@codecov
Copy link

codecov bot commented Mar 21, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ All tests successful. No failed tests found.

📢 Thoughts on this report? Let us know!

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Mar 21, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: b5956392-0764-45a0-89d3-43178f7b36d7

📥 Commits

Reviewing files that changed from the base of the PR and between 254462d and 235de19.

📒 Files selected for processing (1)
  • app/components/Package/Skeleton.vue
🚧 Files skipped from review as they are similar to previous changes (1)
  • app/components/Package/Skeleton.vue

📝 Walkthrough

Walkthrough

Updated layout and utility classes in app/components/Package/Skeleton.vue: header background class changed from bg-[--bg] to bg-bg; header inner layout refactored to use wrapping (flex-wrap) with items-baseline plus explicit gap-x-2/gap-y-1; compare/likes placeholders adjusted to use flex-wrap and removed self-baseline; secondary header divider container updated to include w-full bg-bg sticky top-14 z-10 border-b … pt-2; the sidebar inner wrapper had sticky top-30 xl:top-14 removed while retaining spacing, sizing, overflow and responsive max-height constraints. No exported/public API changes.

Possibly related PRs

Suggested labels

front

Suggested reviewers

  • danielroe
  • alexdln
🚥 Pre-merge checks | ✅ 1
✅ Passed checks (1 passed)
Check name Status Explanation
Description check ✅ Passed The pull request description clearly relates to the changeset, explaining the alignment of skeleton design with the loaded state and referencing specific visual changes.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Contributor

@graphieros graphieros left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is a tiny height difference still:

Image

Copy link
Contributor

@graphieros graphieros left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pixel perfect

@MatteoGabriele MatteoGabriele added this pull request to the merge queue Mar 21, 2026
Merged via the queue into npmx-dev:main with commit eea12a9 Mar 21, 2026
19 checks passed
@MatteoGabriele MatteoGabriele deleted the fix/design-package-skeleton-sidebar branch March 21, 2026 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants