Skip to content

test(ui): set static values for storybook#2174

Merged
ghostdevv merged 1 commit intonpmx-dev:mainfrom
cylewaitforit:sb-static-build-info-values
Mar 20, 2026
Merged

test(ui): set static values for storybook#2174
ghostdevv merged 1 commit intonpmx-dev:mainfrom
cylewaitforit:sb-static-build-info-values

Conversation

@cylewaitforit
Copy link
Contributor

@cylewaitforit cylewaitforit commented Mar 20, 2026

🔗 Linked issue

🧭 Context

Sets static build values so that the visual regression doesn't change between main and PRs.

📚 Description

Diff between tests on PRs and main.

See static values displayed in the footer now in about page story. https://698b88d5157d89f1f33a6c21-wwzembdqtg.chromatic.com/?path=/story/pages-about--default

@vercel
Copy link

vercel bot commented Mar 20, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
npmx.dev Ready Ready Preview, Comment Mar 20, 2026 5:09pm
2 Skipped Deployments
Project Deployment Actions Updated (UTC)
docs.npmx.dev Ignored Ignored Preview Mar 20, 2026 5:09pm
npmx-lunaria Ignored Ignored Mar 20, 2026 5:09pm

Request Review

@codecov
Copy link

codecov bot commented Mar 20, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ All tests successful. No failed tests found.

📢 Thoughts on this report? Let us know!

@ghostdevv ghostdevv added this pull request to the merge queue Mar 20, 2026
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Mar 20, 2026

📝 Walkthrough

Walkthrough

A new conditional branch has been added to the setup function in modules/build-env.ts. When process.env.TEST is false and process.env.STORYBOOK equals "true", the code populates nuxt.options.appConfig.buildInfo with fixed release metadata, including hard-coded version, commit and branch information, along with timestamps derived from a constant date. This logic is inserted before the existing fallback that retrieves environment and build information asynchronously.

Suggested reviewers

  • ghostdevv
🚥 Pre-merge checks | ✅ 1
✅ Passed checks (1 passed)
Check name Status Explanation
Description check ✅ Passed The pull request description is related to the changeset, explaining the motivation for setting static build values in Storybook to prevent visual regression test diffs.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Tip

CodeRabbit can use Trivy to scan for security misconfigurations and secrets in Infrastructure as Code files.

Add a .trivyignore file to your project to customize which findings Trivy reports.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1


ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: c10a24fb-2efb-4571-8e16-2adfcc45a50f

📥 Commits

Reviewing files that changed from the base of the PR and between 4ad0679 and 6ab05c4.

📒 Files selected for processing (1)
  • modules/build-env.ts

Merged via the queue into npmx-dev:main with commit 8ae65d5 Mar 20, 2026
23 checks passed
@cylewaitforit cylewaitforit deleted the sb-static-build-info-values branch March 20, 2026 17:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants