ci: use voidzero-dev/setup-vp instead of setup-node + pnpm/action-setup by fengmk2 · Pull Request #2145 · npmx-dev/npmx.dev

fengmk2 · 2026-03-19T09:07:05Z

🔗 Linked issue

🧭 Context

Replace the two-step setup pattern (actions/setup-node + pnpm/action-setup + pnpm install) with the unified voidzero-dev/setup-vp action across all CI workflows. This simplifies setup to a single step with node-version, cache, and automatic dependency installation via vp.

Replace all pnpm vp commands with vp directly
Build storybook via vp before passing to chromatic action
Migrating .github/workflows/chromatic.yml to setup-vp will fail, so skip it for now.

📚 Description

The time for installing node and dependencies after switching will not be significantly different from before.

vercel · 2026-03-19T09:07:12Z

The latest updates on your projects. Learn more about Vercel for GitHub.

Project	Deployment	Actions	Updated (UTC)
npmx.dev	Ready	Preview, Comment	Mar 20, 2026 8:58am

2 Skipped Deployments

Project	Deployment	Actions	Updated (UTC)
docs.npmx.dev	Ignored	Preview	Mar 20, 2026 8:58am
npmx-lunaria	Ignored		Mar 20, 2026 8:58am

codecov · 2026-03-19T09:09:43Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ All tests successful. No failed tests found.

📢 Thoughts on this report? Let us know!

coderabbitai · 2026-03-19T09:16:55Z

Note

Reviews paused

It looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the reviews.auto_review.auto_pause_after_reviewed_commits setting.

Use the following commands to manage reviews:

@coderabbitai resume to resume automatic reviews.
@coderabbitai review to trigger a single review.

Use the checkboxes below for quick actions:

▶️ Resume reviews
🔍 Trigger review

📝 Walkthrough

Walkthrough

This PR updates five GitHub Actions workflows (.github/workflows/autofix.yml, ci.yml, lunaria.yml, release-pr.yml, release-tag.yml) to replace actions/setup-node and pnpm/action-setup plus explicit pnpm install steps with voidzero-dev/setup-vp@v1 configured with node-version: lts/* and action-level caching where enabled. Invocation of dependency/install/build commands was switched from pnpm ... / pnpm vp ... to vp ... / vp install ..., and some jobs set run-install: false or adjusted install scopes. No source-code exports or public API declarations were changed.

Possibly related PRs

chore: upgrade vite-plus to 0.0.0-g52709db6.20260226-1136 #1668: Changes project scripting to use vp instead of pnpm/vp, matching the workflows' switch to voidzero-dev/setup-vp and vp invocations.

Suggested reviewers

danielroe

🚥 Pre-merge checks | ✅ 1

✅ Passed checks (1 passed)

Check name	Status	Explanation
Description check	✅ Passed	The pull request description clearly relates to the changeset, explaining the replacement of the two-step setup pattern with voidzero-dev/setup-vp and the command changes across CI workflows.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

Create PR with unit tests

📝 Coding Plan

Generate coding plan for human review comments

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

coderabbitai

Actionable comments posted: 3

ℹ️ Review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 9c3bd404-b7d1-4d49-8353-e0d2b01d1d7c

📥 Commits

Reviewing files that changed from the base of the PR and between 5d8fcf5 and 3285237.

📒 Files selected for processing (6)

.github/workflows/autofix.yml
.github/workflows/chromatic.yml
.github/workflows/ci.yml
.github/workflows/lunaria.yml
.github/workflows/release-pr.yml
.github/workflows/release-tag.yml

.github/workflows/ci.yml

.github/workflows/release-tag.yml

coderabbitai

Actionable comments posted: 1

♻️ Duplicate comments (1)

.github/workflows/ci.yml (1)
37-37: ⚠️ Potential issue | 🔴 Critical

vp run lint and vp run knip still appear to target missing scripts.

Line 37 and Line 164 will fail if package.json does not define lint/knip scripts (only lint:fix/knip:fix). This was already raised earlier and still appears unresolved.
#!/bin/bash
set -euo pipefail

echo "=== Workflow commands in CI ==="
rg -n 'run:\s*vp run (lint|knip)' .github/workflows/ci.yml

echo "=== Matching scripts in root package.json ==="
jq -r '.scripts | keys[]' package.json | rg '^(lint|lint:fix|knip|knip:fix)$' || true

echo "=== Explicit values for candidate scripts ==="
jq -r '.scripts["lint"], .scripts["lint:fix"], .scripts["knip"], .scripts["knip:fix"]' package.json
Also applies to: 164-164

ℹ️ Review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: ca1ba98c-d702-4124-bb0b-d31995e64c23

📥 Commits

Reviewing files that changed from the base of the PR and between 3285237 and 9102ca2.

📒 Files selected for processing (5)

.github/workflows/autofix.yml
.github/workflows/ci.yml
.github/workflows/lunaria.yml
.github/workflows/release-pr.yml
.github/workflows/release-tag.yml

✅ Files skipped from review due to trivial changes (1)

.github/workflows/lunaria.yml

🚧 Files skipped from review as they are similar to previous changes (2)

.github/workflows/autofix.yml
.github/workflows/release-tag.yml

.github/workflows/ci.yml

Replace the two-step setup pattern (actions/setup-node + pnpm/action-setup + pnpm install) with the unified voidzero-dev/setup-vp action across all CI workflows. This simplifies setup to a single step with node-version, cache, and automatic dependency installation via vp. - Replace all pnpm vp commands with vp directly - Build storybook via vp before passing to chromatic action

Add run-install: false and manual vp install --filter . --ignore-scripts for lint, i18n, and tag jobs to match original behavior and avoid running heavy postinstall tasks (generate:lexicons, generate:sprite, nuxt prepare) in jobs that don't need them.

Cache is unnecessary when only installing root deps with --ignore-scripts.

coderabbitai

🧹 Nitpick comments (1)

.github/workflows/release-tag.yml (1)
97-101: Keep the publish job on an explicit connector-only install.

setup-vp defaults run-install to true, so this step now does a root-level install before the connector build. That drops the previous connector-only scoping and pulls the workspace root postinstall into the npm publish path, which adds unrelated work and failure modes to a release job. I’d keep auto-install off here and restore the explicit filtered install step instead. (raw.githubusercontent.com)
💡 Minimal change
       - uses: voidzero-dev/setup-vp@73e69397a8b289de4b1d017ced18e18004183bb1 # v1
         with:
           node-version: lts/*
           cache: true
           registry-url: https://registry.npmjs.org
+          run-install: false
Then restore the previous connector-only install step before the build.

ℹ️ Review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: c006621f-ef6c-421c-8392-386888fe02b3

📥 Commits

Reviewing files that changed from the base of the PR and between 586deee and 4a7dbed.

📒 Files selected for processing (5)

.github/workflows/autofix.yml
.github/workflows/ci.yml
.github/workflows/lunaria.yml
.github/workflows/release-pr.yml
.github/workflows/release-tag.yml

🚧 Files skipped from review as they are similar to previous changes (2)

.github/workflows/ci.yml
.github/workflows/autofix.yml

coderabbitai

♻️ Duplicate comments (1)

.github/workflows/release-tag.yml (1)
98-103: ⚠️ Potential issue | 🟡 Minor

registry-url on setup-vp may be a no-op.

Line 101 passes registry-url, but this input may not be supported by voidzero-dev/setup-vp. If unsupported, it is silently ignored and can mislead publish configuration assumptions.
Proposed cleanup
       - uses: voidzero-dev/setup-vp@73e69397a8b289de4b1d017ced18e18004183bb1 # v1
         with:
           node-version: lts/*
-          registry-url: https://registry.npmjs.org
           run-install: false
#!/bin/bash
set -euo pipefail

SHA="73e69397a8b289de4b1d017ced18e18004183bb1"
URL="https://raw.githubusercontent.com/voidzero-dev/setup-vp/${SHA}/action.yml"

echo "Fetching action metadata from pinned SHA: ${SHA}"
curl -fsSL "$URL" | sed -n '/^inputs:/,/^outputs:/p'
Expected result: the inputs section should explicitly list supported keys; verify whether registry-url exists.

ℹ️ Review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: ecaf6580-8b88-439b-88e9-87fe369e75f6

📥 Commits

Reviewing files that changed from the base of the PR and between 4a7dbed and dea629f.

📒 Files selected for processing (5)

.github/workflows/autofix.yml
.github/workflows/ci.yml
.github/workflows/lunaria.yml
.github/workflows/release-pr.yml
.github/workflows/release-tag.yml

🚧 Files skipped from review as they are similar to previous changes (3)

.github/workflows/autofix.yml
.github/workflows/lunaria.yml
.github/workflows/ci.yml

vercel bot deployed to Preview – npmx.dev March 19, 2026 09:09 View deployment

coderabbitai bot reviewed Mar 19, 2026

View reviewed changes

.github/workflows/ci.yml Show resolved Hide resolved

.github/workflows/ci.yml Show resolved Hide resolved

.github/workflows/release-tag.yml Outdated Show resolved Hide resolved

fengmk2 marked this pull request as draft March 19, 2026 11:45

This comment was marked as resolved.

Sign in to view

fengmk2 force-pushed the use-setup-vp-instead branch from 3285237 to da26a9c Compare March 19, 2026 12:02

vercel bot deployed to Preview – npmx.dev March 19, 2026 12:04 View deployment

fengmk2 force-pushed the use-setup-vp-instead branch from da26a9c to 9102ca2 Compare March 19, 2026 12:05

vercel bot deployed to Preview – npmx.dev March 19, 2026 12:07 View deployment

fengmk2 marked this pull request as ready for review March 19, 2026 12:12

coderabbitai bot reviewed Mar 19, 2026

View reviewed changes

.github/workflows/ci.yml Outdated Show resolved Hide resolved

fengmk2 force-pushed the use-setup-vp-instead branch from 9102ca2 to 586deee Compare March 20, 2026 08:23

vercel bot deployed to Preview – npmx.dev March 20, 2026 08:26 View deployment

fengmk2 marked this pull request as draft March 20, 2026 08:30

vercel bot deployed to Preview – npmx.dev March 20, 2026 08:30 View deployment

fengmk2 added 5 commits March 20, 2026 16:30

ci: disable cache for check-only jobs with partial install

332e747

Cache is unnecessary when only installing root deps with --ignore-scripts.

ci: remove unnecessary cache option from check-only jobs

25eec2f

ci: update setup-vp to latest commit 73e69397

f87c32d

fengmk2 force-pushed the use-setup-vp-instead branch from 4a7dbed to f87c32d Compare March 20, 2026 08:30

vercel bot deployed to Preview – npmx.dev March 20, 2026 08:33 View deployment

coderabbitai bot reviewed Mar 20, 2026

View reviewed changes

Fixup

dea629f

fengmk2 marked this pull request as ready for review March 20, 2026 08:39

vercel bot deployed to Preview – npmx.dev March 20, 2026 08:39 View deployment

Fixup

49f6411

fengmk2 requested a review from ghostdevv March 20, 2026 08:42

coderabbitai bot reviewed Mar 20, 2026

View reviewed changes

vercel bot deployed to Preview – npmx.dev March 20, 2026 08:43 View deployment

Merge branch 'main' into use-setup-vp-instead

4bd6527

vercel bot deployed to Preview – npmx.dev March 20, 2026 08:58 View deployment

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

ci: use voidzero-dev/setup-vp instead of setup-node + pnpm/action-setup#2145

ci: use voidzero-dev/setup-vp instead of setup-node + pnpm/action-setup#2145
fengmk2 wants to merge 8 commits intonpmx-dev:mainfrom
fengmk2:use-setup-vp-instead

fengmk2 commented Mar 19, 2026 •

edited

Loading

Uh oh!

vercel bot commented Mar 19, 2026 •

edited

Loading

Uh oh!

codecov bot commented Mar 19, 2026

Uh oh!

coderabbitai bot commented Mar 19, 2026 •

edited

Loading

Reviews paused

Walkthrough

Possibly related PRs

Suggested reviewers

Uh oh!

coderabbitai bot left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

This comment was marked as resolved.

coderabbitai bot left a comment

Uh oh!

Uh oh!

coderabbitai bot left a comment

Uh oh!

coderabbitai bot left a comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Conversation

fengmk2 commented Mar 19, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🔗 Linked issue

🧭 Context

📚 Description

Uh oh!

vercel bot commented Mar 19, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

codecov bot commented Mar 19, 2026

Codecov Report

Uh oh!

coderabbitai bot commented Mar 19, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviews paused

Walkthrough

Possibly related PRs

Suggested reviewers

Uh oh!

coderabbitai bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

This comment was marked as resolved.

coderabbitai bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

coderabbitai bot left a comment

Choose a reason for hiding this comment

Uh oh!

coderabbitai bot left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

fengmk2 commented Mar 19, 2026 •

edited

Loading

vercel bot commented Mar 19, 2026 •

edited

Loading

coderabbitai bot commented Mar 19, 2026 •

edited

Loading