fix(i18n): update Japanese translations#2066
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
2 Skipped Deployments
|
Lunaria Status Overview🌕 This pull request will trigger status changes. Learn moreBy default, every PR changing files present in the Lunaria configuration's You can change this by adding one of the keywords present in the Tracked Files
Warnings reference
|
📝 WalkthroughWalkthroughThis pull request updates the Japanese locale file with new translation entries across several sections. It adds support for multiple Git platform providers (gitlab, bitbucket, codeberg, git_repo, forgejo, gitea, gitee, radicle, sourcehut, and tangled) in the view_on mapping. Additionally, the change introduces new translation keys for UI features including a "most used" grouping option, prediction trend labels, facet-based bar graph descriptions, and view type indicators for table and chart visualisations in the compare section. Possibly related PRs
Suggested reviewers
🚥 Pre-merge checks | ✅ 1✅ Passed checks (1 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
📝 Coding Plan
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment Tip CodeRabbit can suggest fixes for GitHub Check annotations.Configure the |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
| "general_description": "Y軸はダウンロード数、X軸は {start_date} から {end_date} までの期間（単位：{granularity}）を示します。{estimation_notice} {packages_analysis}。{watermark}。", | ||
| "facet_bar_general_description": "{packages} の横棒グラフ: {facet} の比較 ({description})。{facet_analysis} {watermark}。", | ||
| "facet_bar_analysis": "{package_name} の値は {value} です。" |
There was a problem hiding this comment.
Please align placeholder spacing with the ja-JP interpolation convention.
A few placeholders are still adjacent to punctuation without padding, which breaks the project’s Japanese locale consistency rule.
♻️ Suggested consistency fix
- "general_description": "Y軸はダウンロード数、X軸は {start_date} から {end_date} までの期間（単位：{granularity}）を示します。{estimation_notice} {packages_analysis}。{watermark}。",
- "facet_bar_general_description": "{packages} の横棒グラフ: {facet} の比較 ({description})。{facet_analysis} {watermark}。",
+ "general_description": "Y軸はダウンロード数、X軸は {start_date} から {end_date} までの期間（単位： {granularity} ）を示します。 {estimation_notice} {packages_analysis}。 {watermark} 。",
+ "facet_bar_general_description": "{packages} の横棒グラフ: {facet} の比較 ( {description} )。 {facet_analysis} {watermark}。",Based on learnings: In all Japanese translation files (ja-JP.json), placeholders like {about}, {app}, {username} should be padded with spaces around interpolated values for consistency.
There was a problem hiding this comment.
No. These parenthesis, kuten, and touten etc. are special characters usually not padded by spaces in most technical translations in Japanese.
There was a problem hiding this comment.
@shuuji3, understood and thanks for the clarification. Japanese full-width punctuation such as parentheses（）, kuten（。）, and touten（、）are indeed typically not padded with spaces in Japanese technical text — my suggestion was incorrect to apply the spacing rule there. I'll update my long-term memory accordingly.
✏️ Learnings added
Learnt from: shuuji3
Repo: npmx-dev/npmx.dev PR: 2066
File: i18n/locales/ja-JP.json:493-495
Timestamp: 2026-03-13T19:15:58.472Z
Learning: In Japanese translation files (ja-JP.json) for npmx-dev/npmx.dev, the placeholder space-padding convention does NOT apply when a placeholder is adjacent to Japanese special punctuation characters such as full-width parentheses （）, kuten （。）, touten （、）, or similar CJK punctuation. Space padding is only required when a placeholder has plain Japanese prose text (not punctuation) on both sides. For example, "{granularity} ）" or "{watermark}。" should remain without added spaces around the placeholder.
Note: Learnings are effective only in the context of similar code segments. To apply general coding guidelines, please configure review instructions. You can manage existing learnings in the app.
🧠 Learnings used
Learnt from: shuuji3
Repo: npmx-dev/npmx.dev PR: 1461
File: lunaria/files/ja-JP.json:1096-1100
Timestamp: 2026-02-13T08:32:50.257Z
Learning: In all Japanese translation files (ja-JP.json), ensure placeholders like {about}, {app}, {username} are padded with spaces around interpolated values to maintain consistency across i18n entries.
Learnt from: shuuji3
Repo: npmx-dev/npmx.dev PR: 1516
File: lunaria/files/ja-JP.json:307-307
Timestamp: 2026-02-15T07:18:37.542Z
Learning: In Japanese translation files for npmx.dev, placeholders at the beginning or end of strings do not need padding on the boundary side. The space padding convention applies to placeholders that have text on both sides (e.g., "text {placeholder} text"), not to placeholders at string boundaries (e.g., "{placeholder} text" or "text {placeholder}").
Learnt from: shuuji3
Repo: npmx-dev/npmx.dev PR: 862
File: lunaria/files/ja-JP.json:175-182
Timestamp: 2026-02-03T16:44:45.205Z
Learning: In Japanese translations for npmx, keep "Issues" in English when it refers to GitHub Issues, as it is GitHub's canonical term for that feature.
Learnt from: serhalp
Repo: npmx-dev/npmx.dev PR: 1183
File: lunaria/files/uk-UA.json:305-318
Timestamp: 2026-02-08T18:44:10.538Z
Learning: In the npmx.dev project, new or changed entries in i18n translation files (locale JSON files) may be omitted from non-English languages. Translations are not completed in-band in the same PR and are tracked elsewhere. It is acceptable for non-English locale files to be missing keys that exist in English locale files.
Learnt from: userquin
Repo: npmx-dev/npmx.dev PR: 1096
File: i18n/locales/es-419.json:34-41
Timestamp: 2026-02-06T14:53:23.339Z
Learning: In the npmx.dev project, when using country locale variants (e.g., es-419, es-ES), place only translations that differ from the base language in variant JSON files (e.g., es-419.json). The base file (es.json) is loaded first, then the variant file overlays any keys it defines. This behavior is provided by vue-i18n's multiple-files feature. See CONTRIBUTING.md under 'Country variants (advanced)' for details.
Learnt from: mikouaji
Repo: npmx-dev/npmx.dev PR: 2029
File: i18n/locales/pl-PL.json:1220-1220
Timestamp: 2026-03-10T21:43:05.255Z
Learning: Treat the locale key pds.community.new_accounts as intentionally lowercase in all locale files under i18n/locales (and by extension the entire npmx-dev/npmx.dev project). Do not flag capitalization for this key in any locale translations. Apply this exception consistently across all locale JSON files (e.g., i18n/locales/*.json) to avoid false positives when reviewing translations.
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
2 participants
🔗 Linked issue
N/A
🧭 Context
📚 Description