refactor: remove linter warnings#2063
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
2 Skipped Deployments
|
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
📝 WalkthroughWalkthroughThe PR applies consistent internal refactors across many files: several function parameter names were renamed (for example Possibly related PRs
Suggested labels
Suggested reviewers
🚥 Pre-merge checks | ✅ 1✅ Passed checks (1 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
📝 Coding Plan
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
🧹 Nitpick comments (2)
app/composables/useBlogPostBlueskyLink.ts (1)
75-76: Prefer a logger/composable over inline lint suppressionOn Line 75, suppressing
no-consolehides the warning rather than addressing it. Since this path is already dev-only, consider using a project logger utility (or a tiny localdebugLoghelper) and removing the suppression/TODO pair to keep lint rules meaningful.As per coding guidelines: "Add comments only to explain complex logic or non-obvious implementations."
lunaria/components.ts (1)
118-118: Prefer descriptive callback names overlin localisation lookups.Using a single-letter alias makes these predicates harder to scan in an already dense file. A name like
localizationEntry(or similar) will be clearer.As per coding guidelines, "Use clear, descriptive variable and function names".
Also applies to: 152-152, 183-183, 266-266, 293-293, 426-426
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: 004f7562-b45f-468e-b00a-9d99bde2698e
📒 Files selected for processing (19)
.storybook/main.tsapp/components/Compare/FacetBarChart.vueapp/composables/npm/useUserPackages.tsapp/composables/useBlogPostBlueskyLink.tsapp/composables/useFacetSelection.tsapp/composables/useMarkdown.tsapp/pages/search.vueapp/pages/settings.vueapp/utils/download-anomalies.tscli/src/mock-state.tsconfig/i18n.tslunaria/components.tsserver/api/atproto/bluesky-author-profiles.get.tsserver/api/github/contributors-evolution/[owner]/[repo].get.tsserver/api/registry/compare-file/[...pkg].get.tsserver/plugins/payload-cache.tsserver/utils/compare.tstest/unit/app/utils/charts.spec.tstest/unit/app/utils/publish-security.spec.ts
📚 Description
Removes all linter warnings