Conversation
This adds some extra validation and/or sanitisation to two places: - Badges (sanitise values for rendering) - Social websites (yet unused but we don't want to be directing users to `ftp`, custom protocols, etc)
|
The latest updates on your projects. Learn more about Vercel for GitHub.
2 Skipped Deployments
|
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review infoConfiguration used: Organization UI Review profile: CHILL Plan: Pro 📒 Files selected for processing (2)
📝 WalkthroughWalkthroughThis pull request introduces two security and validation enhancements. First, it adds XML escaping functionality to the badge API endpoint to sanitise all user-provided labels and values before embedding them in SVG output across both default and shields-style badge rendering formats. Second, it modifies the profile website field validation to accept only empty strings or URLs starting with http:// or https://, with a runtime check enforcing the URL scheme requirement. Possibly related PRs
Suggested reviewers
🚥 Pre-merge checks | ✅ 1✅ Passed checks (1 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches
🧪 Generate unit tests (beta)
Tip Try Coding Plans. Let us write the prompt for your AI agent so you can ship faster (with fewer bugs). Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This adds some extra validation and/or sanitisation to two places:
ftp, custom protocols, etc)🔗 Linked issue
N/A