Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
2 Skipped Deployments
|
📝 WalkthroughWalkthroughThis pull request replaces inline tooltip markup with a TooltipApp wrapper for avatar and contributor items and adds Possibly related PRs
Suggested reviewers
🚥 Pre-merge checks | ❌ 1❌ Failed checks (1 warning)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
📝 Coding Plan
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
|
have you checked that tooltips display properly with this change? |
|
Sorry, the member list wasn't displayed in my local environment; I overlooked this. Thanks for pointing it out. I'll fix it right away. |
|
@danielroe Are we willing to increase the left and right padding to solve this problem? 🤔 (But we still can't determine how long the user's name is) The current method causes tooltips to be truncated; I've seen a similar issue on the "About" page.
|
|
I think for some reason this doesn't occur on the about page (at least to the left) 🤔 increasing padding doesn't look right |
Perhaps it's because each contributor's username is relatively short. However, when I visit npmx.dev, the "About" page also has a clipping issue because it adds "overflow-x-hidden" to the main box. about-page.mp4 |
|
@RYGRIT can we use TooltipApp in both pages? It should update position automatically |
There was a problem hiding this comment.
🧹 Nitpick comments (1)
app/pages/about.vue (1)
278-278: Consider removingclass="block"to avoid conflicting display values.TooltipBase's root element has
class="inline-flex"(seeapp/components/Tooltip/Base.vue:47). Addingclass="block"here merges both classes, resulting in conflicting CSS display properties. In this grid context (48px cells), it likely has no visual impact, but removing the redundant class would be cleaner.🧹 Suggested simplification
- <TooltipApp :text="`@${contributor.login}`" class="block" position="top"> + <TooltipApp :text="`@${contributor.login}`" position="top">
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: de2db90e-8a05-4bc0-8ede-b9ea5f874a42
📒 Files selected for processing (2)
app/pages/about.vueapp/pages/pds.vue
🚧 Files skipped from review as they are similar to previous changes (1)
- app/pages/pds.vue
|
We can 😅 |

🔗 Linked issue
🧭 Context
📚 Description
pds-page.mp4