Skip to content

fix: correctly exclude primary version from expanded tag list #1802

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
danielroe merged 1 commit into from
Mar 1, 2026
Merged

fix: correctly exclude primary version from expanded tag list #1802

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 9 additions & 5 deletions app/components/Package/Versions.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -427,9 +427,10 @@ function getTagVersions(tag: string): VersionDisplay[] {
return tagVersions.value.get(tag) ?? []
}

// Get filtered versions for a tag (applies semver filter when active)
function getFilteredTagVersions(tag: string): VersionDisplay[] {
const versions = getTagVersions(tag)
// Get the expanded child versions for a tag row (excludes the primary version shown in the row header,
// and applies semver filter when active)
function getExpandedTagVersions(tag: string, primaryVersion: string): VersionDisplay[] {
const versions = getTagVersions(tag).filter(v => v.version !== primaryVersion)
if (!isFilterActive.value) return versions
return versions.filter(v => filteredVersionSet.value.has(v.version))
}
Expand Down Expand Up @@ -670,11 +671,14 @@ function majorGroupContainsCurrent(group: (typeof otherMajorGroups.value)[0]): b

<!-- Expanded versions -->
<div
v-if="expandedTags.has(row.tag) && getFilteredTagVersions(row.tag).length > 1"
v-if="
expandedTags.has(row.tag) &&
getExpandedTagVersions(row.tag, row.primaryVersion.version).length
"
class="ms-4 ps-2 border-is border-border space-y-0.5 pe-2"
>
<div
v-for="v in getFilteredTagVersions(row.tag).slice(1)"
v-for="v in getExpandedTagVersions(row.tag, row.primaryVersion.version)"
:key="v.version"
class="py-1 relative group/version-row hover:bg-bg-elevated/20 focus-within:bg-bg-elevated/20 transition-colors duration-200"
:class="v.version === effectiveCurrentVersion ? 'bg-bg-elevated/20 rounded' : ''"
Expand Down
Loading