Skip to content

test: add provenance tests#1087

Merged
danielroe merged 1 commit intomainfrom
jg/test-proovenancey
Feb 6, 2026
Merged

test: add provenance tests#1087
danielroe merged 1 commit intomainfrom
jg/test-proovenancey

Conversation

@43081j
Copy link
Contributor

@43081j 43081j commented Feb 6, 2026

No description provided.

@vercel
Copy link

vercel bot commented Feb 6, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
npmx.dev Ready Ready Preview, Comment Feb 6, 2026 11:36am
2 Skipped Deployments
Project Deployment Actions Updated (UTC)
docs.npmx.dev Ignored Ignored Preview Feb 6, 2026 11:36am
npmx-lunaria Ignored Ignored Feb 6, 2026 11:36am

Request Review

@codecov
Copy link

codecov bot commented Feb 6, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ All tests successful. No failed tests found.

📢 Thoughts on this report? Let us know!

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Feb 6, 2026

📝 Walkthrough

Walkthrough

This pull request introduces a comprehensive unit test suite for the parseAttestationToProvenanceDetails function in test/unit/server/utils/provenance.spec.ts. The tests validate input handling, DSSE envelope and base64 payload processing, SLSA attestation parsing for both GitHub Actions v1 and GitLab CI attestations, and fallback mechanisms to v0.2 attestations. Coverage includes version precedence logic, provider identification for various builder types, repository URL normalisation by removing trailing slashes and .git suffixes, build file URL extraction, and edge case handling for missing predicates, non-URL invocations, and empty builder identifiers. The addition consists of 426 lines of test code.

Suggested reviewers

  • danielroe
🚥 Pre-merge checks | ❌ 1
❌ Failed checks (1 warning)
Check name Status Explanation Resolution
Description check ⚠️ Warning The pull request has no description provided by the author, making it impossible to assess whether the description relates to the changeset. Add a clear pull request description that explains the purpose of adding the provenance unit tests, what scenarios are covered, and any relevant context for reviewers.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch jg/test-proovenancey

Comment @coderabbitai help to get the list of available commands and usage tips.

@danielroe danielroe added this pull request to the merge queue Feb 6, 2026
Merged via the queue into main with commit 352ec4f Feb 6, 2026
20 checks passed
@danielroe danielroe deleted the jg/test-proovenancey branch February 6, 2026 11:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants