Skip to content

chore: explicitly import node process#1081

Merged
danielroe merged 1 commit intonpmx-dev:mainfrom
iiio2:chore/explicitly-import-node-process
Feb 6, 2026
Merged

chore: explicitly import node process#1081
danielroe merged 1 commit intonpmx-dev:mainfrom
iiio2:chore/explicitly-import-node-process

Conversation

@iiio2
Copy link
Contributor

@iiio2 iiio2 commented Feb 6, 2026

No description provided.

@vercel
Copy link

vercel bot commented Feb 6, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
npmx.dev Ready Ready Preview, Comment Feb 6, 2026 8:56am
2 Skipped Deployments
Project Deployment Actions Updated (UTC)
docs.npmx.dev Ignored Ignored Preview Feb 6, 2026 8:56am
npmx-lunaria Ignored Ignored Feb 6, 2026 8:56am

Request Review

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Feb 6, 2026

📝 Walkthrough

Walkthrough

The pull request adds explicit imports of the Node.js process module to four TypeScript files: modules/lunaria.ts, modules/oauth.ts, modules/runtime/server/cache.ts, and modules/standard-site-sync.ts. Each file receives a single import statement (import process from 'node:process') at the top, enabling direct access to the process object and its properties such as environment variables. No other functional changes or modifications to existing logic are introduced across these modules.

🚥 Pre-merge checks | ❌ 1
❌ Failed checks (1 inconclusive)
Check name Status Explanation Resolution
Description check ❓ Inconclusive The pull request has no description provided by the author, making it impossible to assess the intent or rationale behind the changes. Add a pull request description explaining the purpose and rationale for explicitly importing the node:process module across these modules.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Comment @coderabbitai help to get the list of available commands and usage tips.

@codecov
Copy link

codecov bot commented Feb 6, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ All tests successful. No failed tests found.

📢 Thoughts on this report? Let us know!

Copy link
Contributor

@43081j 43081j left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is what i would do too 👀

if nobody says otherwise ill merge soon 👍

@danielroe danielroe added this pull request to the merge queue Feb 6, 2026
@danielroe
Copy link
Member

we need a lint rule to catch this

Merged via the queue into npmx-dev:main with commit ad56528 Feb 6, 2026
16 checks passed
@iiio2
Copy link
Contributor Author

iiio2 commented Feb 6, 2026

Thanks. 😊

@iiio2 iiio2 deleted the chore/explicitly-import-node-process branch February 6, 2026 13:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants