fix: display images on top of other elements in README#1040
fix: display images on top of other elements in README#1040danielroe merged 1 commit intonpmx-dev:mainfrom
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
2 Skipped Deployments
|
📝 WalkthroughWalkthroughThis pull request addresses styling issues with embedded media (particularly YouTube videos) in the README component. CSS isolation has been applied to the README container to prevent z-index conflicts, and positioning with z-index properties have been added to the main readme image blocks to establish proper stacking context. These are purely visual and layout adjustments with no changes to public APIs or semantic structure. Possibly related PRs
Suggested reviewers
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches🧪 Generate unit tests (beta)
Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
trueberryless
left a comment
There was a problem hiding this comment.
LGTM 🎉
I think we could close the other PR but add the author as a contributor here 👍
|
Cool. |
Resolves #1006
Note: I noticed that the other PR has kind of stalled, so decided to try and fix that myself. Feel free to close this one if it is considered a bad OSS practice.
The change is to display the image on top of other elements with z-index, npm does the same
npmx (fixed)
npm