feat(previous-releases): convert plaintext link to markdown #8452
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
👋 Codeowner Review RequestThe following codeowners have been identified for the changed files: Team reviewers: @nodejs/nodejs-website Please review the changes when you have a chance. Thank you! 🙏 |
| ### Community Installation Methods | ||
|
|
||
| Community installation methods included on the self-service download page (/download) must also adhere to a minimum set of criteria: | ||
| Community installation methods included on the self-service [download page](/download) must also adhere to a minimum set of criteria: |
There was a problem hiding this comment.
This wasn't meant to be a link but to reference "what the self-service download page" is about (so /download) serves as a hint. So I'm unhappy with the proposed changes.
There was a problem hiding this comment.
Thanks for the clarification!
That makes sense - I misunderstood the intention behind the ( /download ) reference.
Would it be acceptable to adjust the wording slightly to make that intent clearer for readers?
For example, something like:
Community installation methods included on the self-service download page (located at /download) must also adhere to a minimum set of criteria:
This would keep it non-linking while making the meaning clearer.
There was a problem hiding this comment.
That would make more sense yes :)
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #8452 +/- ##
==========================================
- Coverage 73.81% 73.77% -0.05%
==========================================
Files 109 109
Lines 9255 9255
Branches 313 314 +1
==========================================
- Hits 6832 6828 -4
- Misses 2421 2425 +4
Partials 2 2 ☔ View full report in Codecov by Sentry. |
No screenshot attached? |
avivkeller
changed the title
|
Apologies for the oversight. I forgot to include the screenshot in the description. |
5 participants
Description
Fixes a broken markdown link on the Previous Releases documentation page where /download was rendered as plain text instead of a clickable link. This change updates the sentence to use proper markdown link syntax for improved usability and consistency across the site.
Validation
/en/about/previous-releases/downloadRelated Issues
Fixes #8451
Check List
pnpm formatto ensure the code follows the style guide.pnpm testto check if all tests are passing.pnpm buildto check if the website builds without errors.