Add version toggle to download page#357
Merged
rnsloan merged 4 commits intonodejs:masterfrom Nov 17, 2015
rnsloan:download-version-toggle
Merged
Add version toggle to download page#357rnsloan merged 4 commits intonodejs:masterfrom rnsloan:download-version-toggle
rnsloan merged 4 commits intonodejs:masterfrom
rnsloan:download-version-toggle
Conversation
Contributor
|
Wow, awesome! 👍 |
Contributor
|
Rally rad! 👍 |
Member
|
It looks great. |
Member
|
+:100: |
Contributor
|
The images look awesome :) has anyone else tested this yet? |
Contributor
|
How about a different active color for LTS and stable, just to indicate which version the user is going to download easier? |
Contributor
|
@diagramatics I was looking at the gif, and noticed that the Windows/OS X/Source parts have a dark gray background on hover. Maybe that could be used? |
Contributor
Author
|
@bnb like this?
|
Contributor
|
@rnsloan Yes, except keep the bright green (from the previous version) for the active state. Notice how the gray background is only visible on hover for the Windows/Mac/Source buttons. Like that, except with the green background as an active state. |
Contributor
Author
|
Colors updated. Merging. |
rnsloan
added a commit
that referenced
this pull request
Nov 17, 2015
Add version toggle to download page
Member
|
👯 nice work! |
Contributor
|
Good job. Looks awesome live! |
Contributor
|
Perfect, Thanks @rnsloan :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #321