chore: improve "We're here for you" callout on Black Lives Matter page#3215
Merged
MylesBorins merged 1 commit intonodejs:masterfrom Jun 5, 2020
Trott:blm5
Merged
chore: improve "We're here for you" callout on Black Lives Matter page#3215MylesBorins merged 1 commit intonodejs:masterfrom Trott:blm5
MylesBorins merged 1 commit intonodejs:masterfrom
Trott:blm5
Conversation
Improve the text and format of the "We're here for you" paragraph by splitting it into multiple sentences/paragraphs. Shorter sentences and repeated structure improve impact. Also added "access" as something Black folks may be seeking rather than limiting it to guidance, mentorship, etc. This was inspired by https://twitter.com/NotNikyatu/status/1268661305843552263.
MylesBorins
approved these changes
Jun 5, 2020
Contributor
MylesBorins
left a comment
MylesBorins
left a comment
There was a problem hiding this comment.
LGTM
I think this is more powerful by splitting it up on separate lines.
Contributor
|
The original section has a grammatical error that is a bit painful to read. I'm going to go a head and land this without any extra review. If anyone thinks this shouldn't have landed or wants to improve the copy please feel free to open a follow up PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Improve the text and format of the "We're here for you" paragraph by
splitting it into multiple sentences/paragraphs. Shorter sentences and
repeated structure improve impact. Also added "access" as something
Black folks may be seeking rather than limiting it to guidance,
mentorship, etc. This was inspired by
https://twitter.com/NotNikyatu/status/1268661305843552263.