Conversation
bnb
changed the title
MylesBorins
approved these changes
Jun 2, 2020
Contributor
MylesBorins
left a comment
MylesBorins
left a comment
There was a problem hiding this comment.
LGTM with small nits
jasnell
reviewed
Jun 2, 2020
codebytere
reviewed
Jun 2, 2020
WaleedAshraf
approved these changes
Jun 2, 2020
Aissaoui-Ahmed
approved these changes
Jun 2, 2020
…names to the lsit Co-authored-by: Black Lives Matter <mylesborins@google.com>
cjihrig
approved these changes
Jun 2, 2020
jasnell
approved these changes
Jun 2, 2020
Contributor
Author
|
Please don't merge yet. |
trivikr
approved these changes
Jun 2, 2020
MylesBorins
reviewed
Jun 2, 2020
…names to the lsit Co-authored-by: Black Lives Matter <mylesborins@google.com>
Co-authored-by: Joe Sepi <sepi@joesepi.com>
MylesBorins
force-pushed
the
black-lives-matter
branch
from
1cf4792 to
deb23ce
Compare
Contributor
|
@bnb my understanding from testing this locally is that there are no redirects. All deep links on the website will continue to work exactly the way the have prior to this PR. This is likely preferred, as taking down nodejs.org/downloads would break node-gyp and a chunk of the internet. |
obensource
reviewed
Jun 4, 2020
Trott
reviewed
Jun 4, 2020
Trott
reviewed
Jun 4, 2020
Trott
reviewed
Jun 4, 2020
yosuke-furukawa
approved these changes
Jun 4, 2020
hiroppy
approved these changes
Jun 4, 2020
Co-authored-by: Ben Michel <ben@obensource.com>
jasnell
approved these changes
Jun 4, 2020
MylesBorins
reviewed
Jun 4, 2020
Co-authored-by: Myles Borins <mylesborins@google.com>
MylesBorins
reviewed
Jun 4, 2020
I'll also love to show my support for African Americans. ✊🏿 Co-authored-by: Myles Borins <mylesborins@google.com>
MylesBorins
reviewed
Jun 4, 2020
Co-authored-by: Tatiana Mac <github@tatianamac.com>
bnb
commented
Jun 4, 2020
Contributor
Author
|
|
bnb
commented
Jun 4, 2020
Co-authored-by: Tierney Cyren <accounts@bnb.im>
Closed
Contributor
|
I've locked this PR as the discussion has resolved and the update to the main page has landed. As mentioned in the original post this decision was made with buy-in from both the TSC and the CommComm More details about our response can be found here |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
20 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a new handlebars template and sets
index.mdto use it. The intent (as discussed with the @nodejs/tsc and @nodejs/community-committee) is to redirect most/all pages to this page for a duration of 7 days from being moved into production. In local testing, this successfully set the main page of the english site to this (I presume we'd want to redirect all languages to this page rather than editing them all).The template is not intended to be locked and can absolutely be modified - to add more names, to add more lists of Black people who have been murdered by the police, to add more TSC and CommComm names to the list of folks to reach out to, and to tweak phrasing/approach based on feedback.
Black Lives Matter.