CSS tweaks.#2620
Closed
XhmikosR wants to merge 1 commit intonodejs:masterfrom
XhmikosR:master-xmr-css-tweaks
Closed
CSS tweaks.#2620XhmikosR wants to merge 1 commit intonodejs:masterfrom XhmikosR:master-xmr-css-tweaks
XhmikosR wants to merge 1 commit intonodejs:masterfrom
XhmikosR:master-xmr-css-tweaks
Conversation
nschonni
reviewed
Oct 16, 2019
Member
nschonni
left a comment
nschonni
left a comment
There was a problem hiding this comment.
I'm not familiar enough with Stylelint to tell if rem can be enforced https://github.com/stylelint/stylelint/blob/master/docs/user-guide/configuration.md#rules
Contributor
Author
|
I could only find https://github.com/meowtec/stylelint-no-px but I don't know if it's worth bothering with it now. You are welcome to try it after this lands :) |
* switch to `rem`s (mostly for font-size for now) * move a few selectors outside of styles.scss * add `margin-bottom` in header logo so that there's more room for tap targets
Contributor
Author
|
I'm gonna drop this for now. We are still blocked by nodejs/build#1947 I might do some of the changes that don't affect the final CSS in another PR. |
This was referenced Nov 26, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
rems (mostly for font-size for now)margin-bottomin header logo so that there's more room for tap targetsI still think many
font-sizes are too small, but this should be tackled separately. In this PR, I tried to keep things consistent with what it was.Preview: https://youthful-nightingale-b83864.netlify.com/en/
Note that this will conflict with #2530 but the Sass switch should probably come first.