Skip to content

Conversation

@santigimeno
Copy link
Member

Checklist
  • make -j8 test (UNIX), or vcbuild test nosign (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)
Description of change

Remove the timer just in case the test takes longer to complete.

It has already failed on the smartos bot: https://ci.nodejs.org/job/node-test-commit-smartos/5075/nodes=smartos14-64/consoleFull

not ok 324 parallel/test-force-repl-with-eval
# /home/iojs/build/workspace/node-test-commit-smartos/nodes/smartos14-64/test/parallel/test-force-repl-with-eval.js:10
#   throw new Error('timeout!');
#   ^
# 
# Error: timeout!
#     at Timeout._onTimeout (/home/iojs/build/workspace/node-test-commit-smartos/nodes/smartos14-64/test/parallel/test-force-repl-with-eval.js:10:9)
#     at ontimeout (timers.js:365:14)
#     at tryOnTimeout (timers.js:237:5)
#     at Timer.listOnTimeout (timers.js:207:5)

@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label Nov 4, 2016
@santigimeno santigimeno added repl Issues and PRs related to the REPL subsystem. smartos Issues and PRs related to the SmartOS platform. labels Nov 4, 2016
Copy link
Member

@Trott Trott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Remove the timer just in case the test takes longer to complete.

PR-URL: nodejs#9460
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
@santigimeno santigimeno merged commit 686b334 into nodejs:master Nov 6, 2016
evanlucas pushed a commit that referenced this pull request Nov 7, 2016
Remove the timer just in case the test takes longer to complete.

PR-URL: #9460
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
MylesBorins pushed a commit that referenced this pull request Nov 22, 2016
Remove the timer just in case the test takes longer to complete.

PR-URL: #9460
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
@MylesBorins MylesBorins mentioned this pull request Nov 22, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

repl Issues and PRs related to the REPL subsystem. smartos Issues and PRs related to the SmartOS platform. test Issues and PRs related to the tests.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants