validate arguments to mustCall(), default value #9035
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updates expected to use modern default syntax and also validate the value and throw an error rather than silently overwriting invalid arguments. Would prevent issues such as the one fixed in the first commit on nodejs#9031
3 tasks
Contributor
Author
|
Doh, the tests don't pass, because this checks for bugs discovered and fixed in #9031 - I'm merging it back into that PR and killing this one. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
make -j8 test(UNIX), orvcbuild test nosign(Windows) passesAffected core subsystem(s)
test
Description of change
Updates the
mustCall()function intest/common.jsto use to default theexpectedparameter to 1 and validate that it is a non-negative number.This change will prevent issues such as the one fixed in the first commit on
#9031