Skip to content

test: use Buffer.from #8748

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
eugeneo wants to merge 0 commits into from
Closed

test: use Buffer.from #8748

eugeneo wants to merge 0 commits into from

Conversation

@eugeneo
Copy link
Contributor

@eugeneo eugeneo commented Sep 23, 2016

Checklist
  • make -j8 test (UNIX), or vcbuild test nosign (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines
Affected core subsystem(s)

Switching to preferred buffer construction method.

Description of change

@mscdex

@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label Sep 23, 2016
eugeneo referenced this pull request Sep 23, 2016
inspector: address race conditions
5acbeb0 
Stress tests uncovered 2 race conditions, when IO events happened during
V8 entering event loop on pause or during Node.js shutdown.

Fixes: #8669
PR-URL: #8672
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: Aleksey Kozyatinskiy <[email protected]>
jasnell
jasnell reviewed Sep 23, 2016
View reviewed changes
test/inspector/inspector-helper.js Outdated
Copy link
Member

@jasnell jasnell Sep 23, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just use Buffer.alloc(0) here and the other places.

Copy link
Member

@jasnell jasnell Sep 23, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:-) ... great timing lol.

Copy link
Contributor Author

@eugeneo eugeneo Sep 23, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

jasnell
jasnell approved these changes Sep 23, 2016
View reviewed changes
Copy link
Member

@jasnell jasnell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mscdex mscdex added the inspector Issues and PRs related to the V8 inspector protocol label Sep 23, 2016
ChALkeR
ChALkeR approved these changes Sep 23, 2016
View reviewed changes
Copy link
Member

@ChALkeR ChALkeR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but the commit message should be altered, this doesn't introduce any new Buffer.from usage anymore =)

imyller
imyller approved these changes Sep 23, 2016
View reviewed changes
Copy link
Member

@imyller imyller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mscdex
Copy link
Contributor

mscdex commented Sep 23, 2016

LGTM

lpinca
lpinca approved these changes Sep 24, 2016
View reviewed changes
Copy link
Member

@lpinca lpinca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

eugeneo pushed a commit that referenced this pull request Sep 26, 2016
test: use Buffer.alloc
af2ca7c 
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Сковорода Никита Андреевич <[email protected]>
Reviewed-By: Ilkka Myller <[email protected]>
Reviewed-By: Brian White <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
PR-URL: #8748
@eugeneo eugeneo closed this Sep 26, 2016
@eugeneo
Copy link
Contributor Author

eugeneo commented Sep 26, 2016

Landed as af2ca7c

jasnell pushed a commit that referenced this pull request Sep 29, 2016
@jasnell
test: use Buffer.alloc
e32f945 
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Сковорода Никита Андреевич <[email protected]>
Reviewed-By: Ilkka Myller <[email protected]>
Reviewed-By: Brian White <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
PR-URL: #8748
geek pushed a commit to geek/node that referenced this pull request Sep 30, 2016
@geek
test: use Buffer.alloc
0f53d9c 
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Сковорода Никита Андреевич <[email protected]>
Reviewed-By: Ilkka Myller <[email protected]>
Reviewed-By: Brian White <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
PR-URL: nodejs#8748
Fishrock123 pushed a commit that referenced this pull request Oct 11, 2016
@Fishrock123
test: use Buffer.alloc
b2aea50 
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Сковорода Никита Андреевич <[email protected]>
Reviewed-By: Ilkka Myller <[email protected]>
Reviewed-By: Brian White <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
PR-URL: #8748
@eugeneo eugeneo deleted the no_ctor branch October 13, 2016 23:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnell jasnell jasnell approved these changes

@lpinca lpinca lpinca approved these changes

@cjihrig cjihrig cjihrig approved these changes

+2 more reviewers

@ChALkeR ChALkeR ChALkeR approved these changes

@imyller imyller imyller approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

inspector Issues and PRs related to the V8 inspector protocol test Issues and PRs related to the tests.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

9 participants

@eugeneo @mscdex @ChALkeR @jasnell @lpinca @imyller @cjihrig @MylesBorins @nodejs-github-bot