Skip to content

Conversation

@cjihrig
Copy link
Contributor

@cjihrig cjihrig commented Jul 22, 2016

Checklist
  • make -j4 test (UNIX), or vcbuild test nosign (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

src

Description of change

The function IsInt64() in node_file.cc is no longer used, and was creating a warning at compile time. This commit removes the unused function.

The function IsInt64() in node_file.cc is no longer used, and
was creating a warning at compile time. This commit removes the
unused function.
@nodejs-github-bot nodejs-github-bot added the c++ Issues and PRs that require attention from people who are familiar with C++. label Jul 22, 2016
@cjihrig
Copy link
Contributor Author

cjihrig commented Jul 22, 2016

@mscdex mscdex added the fs Issues and PRs related to the fs subsystem / file system. label Jul 22, 2016
@mscdex
Copy link
Contributor

mscdex commented Jul 22, 2016

LGTM

@cjihrig
Copy link
Contributor Author

cjihrig commented Jul 23, 2016

Note: If #7846 lands, then this function becomes used again.

@ChALkeR
Copy link
Member

ChALkeR commented Jul 23, 2016

Let's block this until there is a resolution on #7846.

@ChALkeR ChALkeR added the blocked PRs that are blocked by other issues or PRs. label Jul 23, 2016
@jasnell
Copy link
Member

jasnell commented Aug 4, 2016

Given that the decision has been made to do the revert in #7846, this one likely can't land just yet. @cjihrig -- do you want to keep it open and blocked or go ahead and close for now?

@cjihrig
Copy link
Contributor Author

cjihrig commented Aug 4, 2016

I'm fine with leaving it open until there is a proper resolution one way or the other.

@cjihrig
Copy link
Contributor Author

cjihrig commented Aug 5, 2016

This function is used again, as of c5a18e7. Closing this.

@cjihrig cjihrig closed this Aug 5, 2016
@cjihrig cjihrig deleted the unused branch August 5, 2016 13:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

blocked PRs that are blocked by other issues or PRs. c++ Issues and PRs that require attention from people who are familiar with C++. fs Issues and PRs related to the fs subsystem / file system.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants