Skip to content

Conversation

@orangemocha
Copy link
Contributor

Checklist
  • make -j4 test (UNIX), or vcbuild test nosign (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)
Description of change

@nodejs/lts, this is a clean backport of #6675.

Ref: #6675 (comment)

This test fails on WOW64 because of a bug in the OS, and there is
no acceptable workaround.

Ref: nodejs#3667

PR-URL: nodejs#6675
Reviewed-By: bnoordhuis - Ben Noordhuis <[email protected]>
Reviewed-By: cjihrig - Colin Ihrig <[email protected]>
@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label Jul 5, 2016
@jasnell
Copy link
Member

jasnell commented Jul 5, 2016

LGTM

1 similar comment
@MylesBorins
Copy link
Contributor

LGTM

@MylesBorins MylesBorins self-assigned this Jul 5, 2016
@mscdex mscdex added v4.x and removed lts-watch-v4.x labels Jul 5, 2016
@orangemocha
Copy link
Contributor Author

orangemocha commented Jul 8, 2016

CI is green. Landing. Thank you!

https://ci.nodejs.org/job/node-test-commit/4020/

@orangemocha orangemocha merged commit 350e8c6 into nodejs:v4.x-staging Jul 8, 2016
@MylesBorins MylesBorins removed their assignment Dec 27, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

test Issues and PRs related to the tests.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants