sea: print error information when fs operations fail#61581
Closed
joyeecheung wants to merge 2 commits intonodejs:mainfrom
Closed
sea: print error information when fs operations fail#61581joyeecheung wants to merge 2 commits intonodejs:mainfrom
joyeecheung wants to merge 2 commits intonodejs:mainfrom
Conversation
Collaborator
|
Review requested:
|
nodejs-github-bot
added
needs-ci
richardlau
approved these changes
Jan 29, 2026
Member
richardlau
left a comment
richardlau
left a comment
There was a problem hiding this comment.
Is this testable (e.g. passing a non-existent binary in the config?)?
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #61581 +/- ##
==========================================
- Coverage 89.77% 89.76% -0.02%
==========================================
Files 673 673
Lines 203820 203864 +44
Branches 39175 39189 +14
==========================================
+ Hits 182987 183006 +19
- Misses 13152 13187 +35
+ Partials 7681 7671 -10
🚀 New features to boost your workflow:
|
legendecas
approved these changes
Jan 30, 2026
lpinca
approved these changes
Jan 30, 2026
Collaborator
Collaborator
UlisesGascon
approved these changes
Jan 31, 2026
aymen94
approved these changes
Jan 31, 2026
Contributor
|
This is a good change and also my issue is more to do with missing command prompt detection: #61579 (comment) |
joyeecheung
added
commit-queue
nodejs-github-bot
removed
the
commit-queue
Collaborator
|
Landed in baba748...8e41b8d |
nodejs-github-bot
pushed a commit
that referenced
this pull request
Feb 2, 2026
PR-URL: #61581 Refs: #61579 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Chengzhong Wu <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Ulises Gascón <[email protected]>
aduh95
pushed a commit
that referenced
this pull request
Feb 2, 2026
PR-URL: #61581 Refs: #61579 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Chengzhong Wu <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Ulises Gascón <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs: #61579