module: do not wrap module._load when tracing is not enabled #61479
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This prevents clobbering the stack traces with another internal frame and removes the unnecessary hoops from step-debugging.
Collaborator
|
Review requested:
|
nodejs-github-bot
added
module
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #61479 +/- ##
==========================================
- Coverage 91.93% 89.87% -2.06%
==========================================
Files 343 665 +322
Lines 139636 203296 +63660
Branches 22026 39081 +17055
==========================================
+ Hits 128369 182713 +54344
- Misses 11040 12929 +1889
- Partials 227 7654 +7427
🚀 New features to boost your workflow:
|
github-actions
bot
removed
the
request-ci
Collaborator
marco-ippolito
approved these changes
Jan 22, 2026
github-actions
bot
removed
the
request-ci
Collaborator
lpinca
approved these changes
Jan 23, 2026
Collaborator
Collaborator
Collaborator
Collaborator
Qard
approved these changes
Jan 26, 2026
joyeecheung
added
the
commit-queue
nodejs-github-bot
removed
the
commit-queue
Collaborator
|
Landed in 644ba1f |
aduh95
pushed a commit
that referenced
this pull request
Jan 28, 2026
This prevents clobbering the stack traces with another internal frame and removes the unnecessary hoops from step-debugging. PR-URL: #61479 Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Marco Ippolito <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Stephen Belanger <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This prevents clobbering the stack traces with another internal frame and removes the unnecessary hoops from step-debugging.