test: check util.parseArgs argv parsing with actual process execution #61089
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
needs-ci
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #61089 +/- ##
==========================================
- Coverage 88.53% 88.51% -0.02%
==========================================
Files 703 703
Lines 208546 208546
Branches 40217 40224 +7
==========================================
- Hits 184634 184594 -40
- Misses 15926 15962 +36
- Partials 7986 7990 +4 🚀 New features to boost your workflow:
|
cjihrig
approved these changes
Dec 18, 2025
avivkeller
approved these changes
Dec 28, 2025
avivkeller
added
author ready
github-actions
bot
removed
the
request-ci
Collaborator
aduh95
reviewed
Dec 30, 2025
| @@ -1,4 +1,5 @@ | |||
| import { spawnPromisified } from '../common/index.mjs'; | |||
| import { path } from '../common/fixtures.mjs'; | |||
Contributor
There was a problem hiding this comment.
nit: path is usually referring to node:path, it's confusing to have it refer to a function
Suggested change
| import { path } from '../common/fixtures.mjs'; | |
| import * as fixtures from '../common/fixtures.mjs'; |
EDIT: I guess it should be a follow up along with a lint rule
Member
Author
There was a problem hiding this comment.
Both patterns are in common use at the moment, I don't mind changing but it will need following up in either case.
Collaborator
aduh95
added
the
commit-queue
nodejs-github-bot
removed
the
commit-queue
Collaborator
|
Landed in 7b7f693 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new --eval tests for
util.parseArgs()are genuine usage tests that spawn a node instance with command-line args, whereas the existing test for "command-line parsing" just overwritesprocess.argv. Mocking this property is fine for the input parsing tests, but the command-line behaviour should also be genuinely tested here.Refs: #60814