doc: added requestOCSP option to tls.connect
#61064
Merged
+3
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
doc
lpinca
approved these changes
Dec 29, 2025
Fixes nodejs#61042 Put a period at the end of the line Co-authored-by: Luigi Pinca <[email protected]>
bjohansebas
approved these changes
Jan 20, 2026
bjohansebas
added
the
commit-queue
nodejs-github-bot
added
commit-queue-failed
Collaborator
Commit Queue failed- Loading data for nodejs/node/pull/61064 ✔ Done loading data for nodejs/node/pull/61064 ----------------------------------- PR info ------------------------------------ Title doc: added `requestOCSP` option to `tls.connect` (#61064) ⚠ Could not retrieve the email or name of the PR author's from user's GitHub profile! Branch ikeyan:patch-2 -> nodejs:main Labels tls, doc Commits 1 - doc: added `requestOCSP` option to `tls.connect` Committers 1 - 池下 克彦 <[email protected]> PR-URL: https://github.com/nodejs/node/pull/61064 Reviewed-By: Luigi Pinca <[email protected]> ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/61064 Reviewed-By: Luigi Pinca <[email protected]> -------------------------------------------------------------------------------- ⚠ Commits were pushed since the last approving review: ⚠ - doc: added `requestOCSP` option to `tls.connect` ℹ This PR was created on Mon, 15 Dec 2025 02:48:19 GMT ✔ Approvals: 1 ✔ - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/61064#pullrequestreview-3616355195 ✔ Last GitHub CI successful ℹ Green GitHub CI is sufficient -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/21190673214 |
Contributor
Author
|
Hi @bjohansebas, thanks for the review. The Commit Queue only counts approvals from repo collaborators with push/write access, and your approval wasn’t counted by the queue, so it failed. Please ask a collaborator with write access to re‑approve. Thanks! |
Contributor
Author
|
Hi @lpinca, thanks for the approval. The queue flagged "commits were pushed since the last approving review" referencing your approval, meaning the approved commit was replaced after your review. If the current HEAD is still OK, could you re‑approve the PR so the Commit Queue can proceed? Thanks! |
lpinca
approved these changes
Jan 27, 2026
lpinca
added
the
commit-queue
nodejs-github-bot
removed
the
commit-queue
Collaborator
|
Landed in 7c9f5db |
aduh95
pushed a commit
that referenced
this pull request
Jan 28, 2026
Fixes #61042 Put a period at the end of the line Co-authored-by: Luigi Pinca <[email protected]> PR-URL: #61064 Reviewed-By: Luigi Pinca <[email protected]>
aduh95
pushed a commit
that referenced
this pull request
Feb 3, 2026
Fixes #61042 Put a period at the end of the line Co-authored-by: Luigi Pinca <[email protected]> PR-URL: #61064 Reviewed-By: Luigi Pinca <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #61042