Skip to content

Conversation

@SimonSchick
Copy link
Contributor

See #59321 and #51485 for implementation

@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/test_runner

@nodejs-github-bot nodejs-github-bot added doc Issues and PRs related to the documentations. test_runner Issues and PRs related to the test runner subsystem. labels Aug 1, 2025
@SimonSchick SimonSchick changed the title docs(test): add missing docs for passed and error properties on TextContext docs(test): add missing passed and error on TextContext Aug 1, 2025
@SimonSchick SimonSchick changed the title docs(test): add missing passed and error on TextContext doc(test): add missing passed and error on TextContext Aug 1, 2025
@SimonSchick SimonSchick force-pushed the docs/missing-test-context-properties branch from 485f8ca to 24c4abc Compare August 1, 2025 21:34
@SimonSchick SimonSchick force-pushed the docs/missing-test-context-properties branch from 24c4abc to 7ddb4dc Compare August 1, 2025 21:36
Copy link
Member

@JakobJingleheimer JakobJingleheimer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for raising.

I wasn't aware of this functionality; I'll check the implementation this weekend to confirm.

Co-authored-by: Jacob Smith <[email protected]>
Copy link
Member

@JakobJingleheimer JakobJingleheimer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙌

@JakobJingleheimer JakobJingleheimer added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. labels Aug 11, 2025
### `context.passed` {boolean}

<!-- YAML
added: v20.12.0
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

According to the PR you linked

Suggested change
added: v20.12.0
added:
- v21.7.0
- v20.12.0

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@aduh95 should we land it as is and have a follow-up PR? This seems to already improve the situation over what we have right now.

### `context.error` {Error|null}

<!-- YAML
added: v20.12.0
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same here I reckon

Suggested change
added: v20.12.0
added:
- v21.7.0
- v20.12.0

added: v20.12.0
-->

The failure reason for the test/case; if anything other than an instance of `Error` was thrown, that will be wrapped
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit

Suggested change
The failure reason for the test/case; if anything other than an instance of `Error` was thrown, that will be wrapped
The failure reason for the test/case; if anything other than an instance of {Error} was thrown, that will be wrapped

@SimonSchick SimonSchick closed this Dec 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author ready PRs that have at least one approval, no pending requests for changes, and a CI started. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. doc Issues and PRs related to the documentations. test_runner Issues and PRs related to the test runner subsystem.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants