Skip to content

inspector: add mimeType and charset support to Network.Response #58192

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nodejs-github-bot merged 4 commits into from
May 28, 2025
Merged

inspector: add mimeType and charset support to Network.Response #58192

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
aedcacc
inspector: add mimeType and charset support to Network.Response
islandryu May 6, 2025
255e375
fallback to empty string if charset param is missing
islandryu May 7, 2025
40d0ff9
default empty string
islandryu May 20, 2025
004588e
fix intend
islandryu May 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/inspector/network_agent.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -171,12 +171,12 @@ std::unique_ptr<protocol::Network::Response> createResponseFromObject(

protocol::String mimeType;
if (!ObjectGetProtocolString(context, response, "mimeType").To(&mimeType)) {
return {};
mimeType = protocol::String("");
}

protocol::String charset = protocol::String();
if (!ObjectGetProtocolString(context, response, "charset").To(&charset)) {
return {};
charset = protocol::String("");
Copy link
Member Author

@islandryu islandryu May 20, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After merging with main, the parallel/test-inspector-network-content-type test was failing, so I made some changes.
I believe setting the default to an empty string shouldn't cause any issues.

}

return protocol::Network::Response::create()
Expand Down
Loading