Skip to content

Conversation

@AndreasMadsen
Copy link
Member

Pull Request check-list

Please make sure to review and check all of these items:

  • Does make -j8 test (UNIX) or vcbuild test nosign (Windows) pass with
    this change (including linting)?
  • Is the commit message formatted according to CONTRIBUTING.md?
  • If this change fixes a bug (or a performance problem), is a regression
    test (or a benchmark) included?
  • Is a documentation update included (if this change modifies
    existing APIs, or introduces new ones)?

NOTE: these things are not required to open a PR and can be done
afterwards / while the PR is open.

Affected core subsystem(s)

doc

Description of change

Adding myself to the collaborator list

@AndreasMadsen AndreasMadsen added the doc Issues and PRs related to the documentations. label Mar 11, 2016
@AndreasMadsen
Copy link
Member Author

@GlenTiki
Copy link
Contributor

LGTM

1 similar comment
@evanlucas
Copy link
Contributor

LGTM

@Fishrock123
Copy link
Contributor

PR-URL: https://github.com/nodejs/node/pull/5666 LGTM

@AndreasMadsen
Copy link
Member Author

Landed in 0ed4665

@AndreasMadsen AndreasMadsen deleted the collab-add-myself branch March 11, 2016 22:17
@rvagg
Copy link
Member

rvagg commented Mar 14, 2016

Woot! Welcome @AndreasMadsen!

evanlucas pushed a commit that referenced this pull request Mar 14, 2016
PR-URL: #5666
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Evan Lucas <[email protected]>
Reviewed-By: Glen Keane <[email protected]>
@evanlucas evanlucas mentioned this pull request Mar 14, 2016
rvagg pushed a commit that referenced this pull request Mar 16, 2016
PR-URL: #5666
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Evan Lucas <[email protected]>
Reviewed-By: Glen Keane <[email protected]>
@MylesBorins
Copy link
Contributor

🎉

MylesBorins pushed a commit that referenced this pull request Mar 17, 2016
PR-URL: #5666
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Evan Lucas <[email protected]>
Reviewed-By: Glen Keane <[email protected]>
MylesBorins pushed a commit that referenced this pull request Mar 21, 2016
PR-URL: #5666
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Evan Lucas <[email protected]>
Reviewed-By: Glen Keane <[email protected]>
MylesBorins pushed a commit that referenced this pull request Mar 21, 2016
PR-URL: #5666
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Evan Lucas <[email protected]>
Reviewed-By: Glen Keane <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

doc Issues and PRs related to the documentations.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants