-
-
Notifications
You must be signed in to change notification settings - Fork 34.2k
util: add sourcemap support to getCallSites #55589
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Review requested:
|
9e2675f to
b31da8d
Compare
b31da8d to
9777431
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #55589 +/- ##
==========================================
- Coverage 88.40% 88.40% -0.01%
==========================================
Files 654 654
Lines 187637 187640 +3
Branches 36098 36103 +5
==========================================
- Hits 165887 165879 -8
- Misses 14994 15002 +8
- Partials 6756 6759 +3
🚀 New features to boost your workflow:
|
9777431 to
13ad74f
Compare
2bc03cf to
fe8f181
Compare
This comment was marked as outdated.
This comment was marked as outdated.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree that if we want to fix #55109 instead of adding a new function, we should just improve the support of the existing util.getCallSite(). What about accepting a config and then proceeding with module mapping inside node:util?
With a new function it is more flexibile because you can decide which frame to map, instead of mapping all of them, and you can also mock. |
This comment was marked as outdated.
This comment was marked as outdated.
This comment has been minimized.
This comment has been minimized.
|
Not a big fan of the polymorphism that derived from the ambiguity of the name Submitted #55626 to not hijacking this thread. |
507688e to
c1bc9e4
Compare
c1bc9e4 to
a9977d8
Compare
|
This commit does not land cleanly on |
Fixes: #55109