doc: use gcc 12 on AIX for Node.js >=23 #54338
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use gcc 12 to build the official binaries for Node.js 23 onwards on AIX. Note that this will require `libstdc++12`, available from the AIX toolbox.
nodejs-github-bot
added
build
richardlau
added
semver-major
Contributor
|
The
notable-change
Please suggest a text for the release notes if you'd like to include a more detailed summary, then proceed to update the PR description with the text or a link to the notable change suggested text comment. Otherwise, the commit will be placed in the Other Notable Changes section. |
17 tasks
anonrig
approved these changes
Aug 12, 2024
UlisesGascon
approved these changes
Aug 13, 2024
aymen94
approved these changes
Aug 13, 2024
lpinca
approved these changes
Aug 13, 2024
joyeecheung
added
the
commit-queue
nodejs-github-bot
removed
the
commit-queue
Collaborator
Commit Queue failed- Loading data for nodejs/node/pull/54338 ✔ Done loading data for nodejs/node/pull/54338 ----------------------------------- PR info ------------------------------------ Title doc: use gcc 12 on AIX for Node.js >=23 (#54338) ⚠ Could not retrieve the email or name of the PR author's from user's GitHub profile! Branch richardlau:building -> nodejs:main Labels doc, semver-major, build, aix, notable-change Commits 1 - doc: use gcc 12 on AIX for Node.js >=23 Committers 1 - Richard Lau <[email protected]> PR-URL: https://github.com/nodejs/node/pull/54338 Refs: https://github.com/nodejs/build/issues/3806 Refs: https://github.com/nodejs/build/pull/3858 Refs: https://github.com/nodejs/node/pull/54081 Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Ulises Gascón <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/54338 Refs: https://github.com/nodejs/build/issues/3806 Refs: https://github.com/nodejs/build/pull/3858 Refs: https://github.com/nodejs/node/pull/54081 Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Ulises Gascón <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> -------------------------------------------------------------------------------- ℹ This PR was created on Mon, 12 Aug 2024 16:40:28 GMT ✔ Approvals: 3 ✔ - Yagiz Nizipli (@anonrig) (TSC): https://github.com/nodejs/node/pull/54338#pullrequestreview-2233571242 ✔ - Ulises Gascón (@UlisesGascon): https://github.com/nodejs/node/pull/54338#pullrequestreview-2234636271 ✔ - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/54338#pullrequestreview-2235922426 ✘ semver-major requires at least 2 TSC approvals ✔ Last GitHub CI successful ℹ Green GitHub CI is sufficient -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/10402872590 |
nodejs-github-bot
added
the
commit-queue-failed
richardlau
removed
the
commit-queue-failed
Member
Author
This is semver-major, so requires another @nodejs/tsc approval. |
targos
approved these changes
Aug 16, 2024
richardlau
added
the
commit-queue
nodejs-github-bot
removed
the
commit-queue
Collaborator
|
Landed in 7fab6e8 |
This was referenced Feb 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use gcc 12 to build the official binaries for Node.js 23 onwards on AIX. Note that this will require
libstdc++12, available from the AIX toolbox.Refs: nodejs/build#3806
Refs: nodejs/build#3858
Refs: #54081