deps: update nghttp2 to 1.57.0#50121
Merged
nodejs-github-bot merged 1 commit intonodejs:mainfrom Oct 11, 2023
Merged
Conversation
Collaborator
|
Review requested:
|
nodejs-github-bot
added
http2
This comment was marked as outdated.
This comment was marked as outdated.
jasnell
force-pushed
the
update-nghttp2-1.57.0
branch
from
7979e0c to
037ed4f
Compare
This comment was marked as outdated.
This comment was marked as outdated.
jasnell
force-pushed
the
update-nghttp2-1.57.0
branch
from
037ed4f to
d14b7ac
Compare
Collaborator
Member
|
I recommend fast tracking this |
Contributor
|
Fast-track has been requested by @mcollina. Please 👍 to approve. |
marco-ippolito
approved these changes
Oct 10, 2023
Member
marco-ippolito
left a comment
marco-ippolito
left a comment
There was a problem hiding this comment.
LGTM, any reason for manually updating rather than waiting for the action?
Member
Author
The action misses the addition of new files to the source list in the gyp file |
Member
Author
|
Looks like CI is having some of it's typical issues. I'm going to be tied up for a bit if someone else could please help babysit CI to get this landed as soon as it's ready. |
tniessen
approved these changes
Oct 10, 2023
Collaborator
30 tasks
Collaborator
richardlau
added
the
commit-queue
nodejs-github-bot
removed
the
commit-queue
Collaborator
|
Landed in dc1c50b |
richardlau
pushed a commit
that referenced
this pull request
Oct 11, 2023
PR-URL: #50121 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Michael Dawson <midawson@redhat.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de>
This was referenced Aug 4, 2025
This was referenced Aug 18, 2025
This was referenced Sep 1, 2025
This was referenced Sep 15, 2025
This was referenced Sep 29, 2025
This was referenced Oct 13, 2025
This was referenced Oct 27, 2025
This was referenced Nov 10, 2025
This was referenced Dec 1, 2025
This was referenced Jan 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
10 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.