Skip to content

vm: support negative number lineOffset and columnOffset #48169

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
sinkhaha wants to merge 4 commits into from
Closed

vm: support negative number lineOffset and columnOffset #48169

sinkhaha wants to merge 4 commits into from

Conversation

@sinkhaha
Copy link
Contributor

@sinkhaha sinkhaha commented May 25, 2023

Fixes: #43207

Checklist

  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. vm Issues and PRs related to the vm subsystem. labels May 25, 2023
@sinkhaha
Copy link
Contributor Author

sinkhaha commented May 26, 2023

cc @bnoordhuis

@sinkhaha
Copy link
Contributor Author

sinkhaha commented Jul 11, 2023

Can this PR be merged

@sinkhaha sinkhaha closed this Jan 8, 2024
@fhinkel
Copy link
Member

fhinkel commented Jan 28, 2024 •
edited
Loading

👋 @sinkhaha ! Thanks for your contribution! Looks like somebody else opened a duplicate issue and the fix was merged before this PR was completed. Apologies for the overlap. The fix landed in Node 20.

This as a duplicate of #49855

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnell jasnell jasnell approved these changes

@JungMinu JungMinu JungMinu approved these changes

Assignees

No one assigned

Labels

needs-ci PRs that need a full CI run. vm Issues and PRs related to the vm subsystem.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

vm.compileFunction throws an RangeError when invoked with options.lineOffset < 0

5 participants

@sinkhaha @fhinkel @jasnell @JungMinu @nodejs-github-bot