crypto: simplify control flow in HKDF #44272
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Unify the implementation and perform the same OpenSSL calls regardless of whether the key and/or salt are empty. This simplifies the code and improves coverage. Refs: nodejs#44201
tniessen
added
crypto
Collaborator
|
Review requested:
|
panva
added
author ready
panva
approved these changes
Aug 18, 2022
github-actions
bot
removed
the
request-ci
Collaborator
Member
Author
|
cc @nodejs/cpp-reviewers |
Member
|
Applied https://github.com/nodejs/node/labels/dont-land-on-v16.x because this uses |
tniessen
added
the
commit-queue
nodejs-github-bot
removed
the
commit-queue
Collaborator
|
Landed in 4d49d65 |
sidwebworks
pushed a commit
to sidwebworks/node
that referenced
this pull request
Aug 26, 2022
Unify the implementation and perform the same OpenSSL calls regardless of whether the key and/or salt are empty. This simplifies the code and improves coverage. Refs: nodejs#44201 PR-URL: nodejs#44272 Reviewed-By: Filip Skokan <[email protected]>
RafaelGSS
pushed a commit
that referenced
this pull request
Sep 5, 2022
Unify the implementation and perform the same OpenSSL calls regardless of whether the key and/or salt are empty. This simplifies the code and improves coverage. Refs: #44201 PR-URL: #44272 Reviewed-By: Filip Skokan <[email protected]>
Fyko
pushed a commit
to Fyko/node
that referenced
this pull request
Sep 15, 2022
Unify the implementation and perform the same OpenSSL calls regardless of whether the key and/or salt are empty. This simplifies the code and improves coverage. Refs: nodejs#44201 PR-URL: nodejs#44272 Reviewed-By: Filip Skokan <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unify the implementation and perform the same OpenSSL calls regardless of whether the key and/or salt are empty. This simplifies the code and improves coverage.
Refs: #44201