Skip to content

doc: improve callback params for fs.mkdir #43016

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nodejs-github-bot merged 2 commits into from
May 22, 2022
Merged

doc: improve callback params for fs.mkdir #43016

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e59a104
doc: improve callback params for `fs.mkdir`
daeyeon May 9, 2022
d741758
fix: apply the specification
daeyeon May 9, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions doc/api/fs.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2988,6 +2988,7 @@ changes:
* `mode` {string|integer} Not supported on Windows. **Default:** `0o777`.
* `callback` {Function}
* `err` {Error}
* `path` {string|undefined}
Copy link
Contributor

@aduh95 aduh95 May 9, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It'd be nice to specify that that argument won't be present most of the times.

Suggested change
* `path` {string|undefined}
* `path` {string|undefined} Present only if a directory is created with `recursive` set to `true`.

Copy link
Member Author

@daeyeon daeyeon May 9, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Applied the suggestion.


Asynchronously creates a directory.

Expand Down