Skip to content

test_crypto_engine: depends on non-shared openssl #40965

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
minrk wants to merge 1 commit into from
Closed

test_crypto_engine: depends on non-shared openssl #40965

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion node.gyp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1476,7 +1476,7 @@
}], # end aix section
# TODO(RaisinTen): Enable this to build on other platforms as well.
['(OS=="mac" or (OS=="linux" and target_arch=="x64")) and \
node_use_openssl=="true"', {
node_use_openssl=="true" and node_shared_openssl=="false"', {
Copy link
Member

@RaisinTen RaisinTen Nov 27, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests are failing. I think you need to add this conditional:

if (process.config.variables.node_shared_openssl === false)

around

node/test/parallel/test-crypto-engine.js

Line 31 in eadfbae

{
to fix the failure.

'targets': [
{
'target_name': 'test_crypto_engine',
Expand Down