crypto: remove check for condition that is always true #38072
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The value of `key` will always be `!= null` because earlier in the function, `ERR_CRYPTO_SIGN_KEY_REQUIRED` is thrown if `key` is falsy. Remove condition that subsequently checks that `key != null`.
nodejs-github-bot
added
crypto
This comment has been minimized.
This comment has been minimized.
aduh95
approved these changes
Apr 4, 2021
This comment has been minimized.
This comment has been minimized.
RaisinTen
approved these changes
Apr 4, 2021
RaisinTen
added
the
author ready
cjihrig
approved these changes
Apr 4, 2021
lpinca
approved these changes
Apr 4, 2021
This comment has been minimized.
This comment has been minimized.
panva
approved these changes
Apr 5, 2021
jasnell
approved these changes
Apr 6, 2021
Collaborator
Member
|
Landed in 1e4a2bc |
jasnell
pushed a commit
that referenced
this pull request
Apr 6, 2021
The value of `key` will always be `!= null` because earlier in the function, `ERR_CRYPTO_SIGN_KEY_REQUIRED` is thrown if `key` is falsy. Remove condition that subsequently checks that `key != null`. PR-URL: #38072 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Darshan Sen <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Filip Skokan <[email protected]> Reviewed-By: James M Snell <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The value of
keywill always be!= nullbecause earlier in thefunction,
ERR_CRYPTO_SIGN_KEY_REQUIREDis thrown ifkeyis falsy.Remove condition that subsequently checks that
key != null.