Skip to content

Conversation

@watilde
Copy link
Contributor

@watilde watilde commented Sep 24, 2020

Refs: web-platform-tests/wpt#25542

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines

@watilde watilde added test Issues and PRs related to the tests. encoding Issues and PRs related to the TextEncoder and TextDecoder APIs. labels Sep 24, 2020
@watilde watilde added the request-ci Add this label to start a Jenkins CI on a PR. label Sep 27, 2020
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Sep 27, 2020
@nodejs-github-bot
Copy link
Collaborator

@watilde
Copy link
Contributor Author

watilde commented Sep 28, 2020

Rebased to fix conflicts

@watilde watilde added the request-ci Add this label to start a Jenkins CI on a PR. label Sep 28, 2020
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Sep 28, 2020
@nodejs-github-bot
Copy link
Collaborator

watilde added a commit that referenced this pull request Sep 28, 2020
Refs: web-platform-tests/wpt#25542

PR-URL: #35330
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Shingo Inoue <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
@watilde
Copy link
Contributor Author

watilde commented Sep 28, 2020

Landed in 6fc3b0d

@watilde watilde closed this Sep 28, 2020
@watilde watilde deleted the test/encoding branch September 28, 2020 05:09
@MylesBorins
Copy link
Contributor

hey @watilde this doesn't land cleanly on v14.x, would you be able to backport?

watilde added a commit to watilde/node that referenced this pull request Sep 30, 2020
Refs: web-platform-tests/wpt#25542

PR-URL: nodejs#35330
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Shingo Inoue <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
@watilde
Copy link
Contributor Author

watilde commented Sep 30, 2020

@MylesBorins Yes, I just made it on #35422 :)

@danielleadams danielleadams mentioned this pull request Oct 6, 2020
danielleadams pushed a commit that referenced this pull request Oct 6, 2020
Refs: web-platform-tests/wpt#25542

PR-URL: #35330
Backport-PR-URL: #35422
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Shingo Inoue <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
joesepi pushed a commit to joesepi/node that referenced this pull request Jan 8, 2021
Refs: web-platform-tests/wpt#25542

PR-URL: nodejs#35330
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Shingo Inoue <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

encoding Issues and PRs related to the TextEncoder and TextDecoder APIs. test Issues and PRs related to the tests.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants