test: fix message/esm_loader_not_found_cjs_hint_bare#34764
Closed
addaleax wants to merge 1 commit intonodejs:masterfrom
Closed
test: fix message/esm_loader_not_found_cjs_hint_bare#34764addaleax wants to merge 1 commit intonodejs:masterfrom
addaleax wants to merge 1 commit intonodejs:masterfrom
Conversation
Broken locally for me since f8976a7. Refs: nodejs#34744
addaleax
added
test
Member
Author
|
Please 👍 this comment to approve fast-tracking (assuming it passes CI, not sure if it’s broken only for me locally?) |
github-actions
bot
removed
the
request-ci
Collaborator
Contributor
|
This was a necessary fix to get the tests to pass, since |
Contributor
|
Let's see how the CI looks. Are you running a Mac? |
jasnell
approved these changes
Aug 13, 2020
Member
Author
|
Yeah, sorry. I’ll try to figure out what went wrong here, but it’s almost certainly something on my end. Oops! |
This was referenced Aug 15, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Broken locally for me since f8976a7.
Refs: #34744
@guybedford @jasnell @jkrems Fyi
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes