Skip to content

Conversation

@MarcelRaschke
Copy link

@MarcelRaschke MarcelRaschke commented Jul 27, 2020

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • [ x] commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added cli Issues and PRs related to the Node.js command line interface. doc Issues and PRs related to the documentations. labels Jul 27, 2020
Copy link
Member

@BridgeAR BridgeAR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RSLGTM

@richardlau
Copy link
Member

Isn't this #31360?

@MarcelRaschke MarcelRaschke requested a review from BridgeAR August 3, 2020 15:27
@Trott
Copy link
Member

Trott commented Aug 11, 2020

Welcome, @MarcelRaschke and thanks for the pull request. It appears that this has already been corrected in the docs. Thank you anyway and hope to see you contribute more!

@Trott Trott closed this Aug 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cli Issues and PRs related to the Node.js command line interface. doc Issues and PRs related to the documentations.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants