repl: remove deprecated repl features #33286
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mscdex
added
the
semver-major
Collaborator
|
CI: https://ci.nodejs.org/job/node-test-pull-request/31241/ ✔️ (yellow build) |
Collaborator
Member
Author
|
@nodejs/repl @nodejs/tsc PTAL. CITGM looks good. |
Member
LGTM but I'd prefer to let someone with more REPL domain knowledge weigh in first. (But if that doesn't happen, I'll +1 this to help avoid it getting completely stalled.) |
targos
approved these changes
May 10, 2020
BridgeAR
force-pushed
the
remove-deprecated-repl-functions
branch
from
8c9db59 to
046721d
Compare
Collaborator
jasnell
approved these changes
May 11, 2020
BridgeAR
added
the
author ready
BridgeAR
force-pushed
the
remove-deprecated-repl-functions
branch
from
046721d to
0455535
Compare
Collaborator
Collaborator
The .rli property is just a reference to the active REPL instance and it was deprecated for a long time. To improve maintainability of the REPL this feature is removed. Signed-off-by: Ruben Bridgewater <[email protected]>
This property is deprecated since Node.js v9.0.0 and to improve maintainability of the REPL it is now removed. Signed-off-by: Ruben Bridgewater <[email protected]>
This removes the deprecated REPLServer.parseREPLKeyword function. It is deprecated for a long time and should not provide any benefit to users. To improve the maintainability of the REPL module, it's now removed. Signed-off-by: Ruben Bridgewater <[email protected]>
This function is deprecated for multiple years and provides very little benefit to users. Thus, it's removed to improve the maintainability of the REPL module. Signed-off-by: Ruben Bridgewater <[email protected]>
BridgeAR
force-pushed
the
remove-deprecated-repl-functions
branch
from
0455535 to
551f4c4
Compare
Collaborator
This removes the memory function. It is deprecated for a long time while not being really helpful being exposed. Thus, it is removed to improve maintainability of the REPL module. Signed-off-by: Ruben Bridgewater <[email protected]>
BridgeAR
force-pushed
the
remove-deprecated-repl-functions
branch
from
551f4c4 to
eae6e38
Compare
Collaborator
Collaborator
Collaborator
Member
Author
|
Landed in e88d098...a416692 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
repl: remove deprecated .rli
The .rli property is just a reference to the active REPL instance
and it was deprecated for a long time.
To improve maintainability of the REPL this feature is removed.
repl: remove deprecated bufferedCommand property
This property is deprecated since Node.js v9.0.0 and to improve
maintainability of the REPL it is now removed.
repl: remove deprecated repl.parseREPLKeyword() function
This removes the deprecated REPLServer.parseREPLKeyword function. It
is deprecated for a long time and should not provide any benefit to
users. To improve the maintainability of the REPL module, it's now
removed.
repl: remove deprecated repl.turnOffEditorMode() function
This function is deprecated for multiple years and provides very
little benefit to users. Thus, it's removed to improve the
maintainability of the REPL module.
repl: remove deprecated repl.memory function
This removes the memory function. It is deprecated for a long time
while not being really helpful being exposed. Thus, it is removed
to improve maintainability of the REPL module.
@nodejs/repl PTAL
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes