Skip to content

test: fix test-benchmark-net #29359

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
Trott wants to merge 1 commit into from
Closed

test: fix test-benchmark-net #29359

Trott wants to merge 1 commit into from

Conversation

@Trott
Copy link
Member

@Trott Trott commented Aug 28, 2019

Fix test-benchmark-net to accommodate recent benchmark additions.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@Trott
test: fix test-benchmark-net
e61ebb3 
Fix test-benchmark-net to accommodate recent benchmark additions.
@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label Aug 28, 2019
@Trott Trott added fast-track PRs that do not need to wait for 48 hours to land. and removed test Issues and PRs related to the tests. labels Aug 28, 2019
@Trott
Copy link
Member Author

Trott commented Aug 28, 2019

Collaborators, 👍 here to fast-track. (node-daily-master will fail until this fix or similar lands.)

@Trott
Copy link
Member Author

Trott commented Aug 28, 2019

Lite CI: https://ci.nodejs.org/job/node-test-pull-request-lite-pipeline/3865/

Benchmark test CI: https://ci.nodejs.org/job/node-test-commit-custom-suites-freestyle/8798/

@Trott Trott added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Aug 28, 2019
@Trott
Copy link
Member Author

Trott commented Aug 28, 2019

Landed in 167960f

@Trott Trott closed this Aug 28, 2019
Trott added a commit to Trott/io.js that referenced this pull request Aug 28, 2019
@Trott
test: fix test-benchmark-net
167960f 
Fix test-benchmark-net to accommodate recent benchmark additions.

PR-URL: nodejs#29359
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
BridgeAR pushed a commit that referenced this pull request Sep 3, 2019
@Trott @BridgeAR
test: fix test-benchmark-net
a7faef9 
Fix test-benchmark-net to accommodate recent benchmark additions.

PR-URL: #29359
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
@BridgeAR BridgeAR mentioned this pull request Sep 3, 2019
Merged
BridgeAR pushed a commit that referenced this pull request Sep 4, 2019
@Trott @BridgeAR
test: fix test-benchmark-net
83fb133 
Fix test-benchmark-net to accommodate recent benchmark additions.

PR-URL: #29359
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
@Trott Trott deleted the fix-test-benchmark-net branch January 13, 2022 22:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@addaleax addaleax addaleax approved these changes

@cjihrig cjihrig cjihrig approved these changes

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no pending requests for changes, and a CI started. fast-track PRs that do not need to wait for 48 hours to land.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Trott @addaleax @cjihrig @nodejs-github-bot