src: implement special member functions for Environment #28579
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
the
c++
GauthamBanasandra
force-pushed
the
ctors
branch
2 times, most recently
from
b8366b2 to
f7cb4f4
Compare
bnoordhuis
requested changes
Jul 8, 2019
Member
bnoordhuis
left a comment
bnoordhuis
left a comment
There was a problem hiding this comment.
Your PR contains a lot of stylistic changes. Can you undo those please? We don't accept style changes as a rule and it makes code review a lot more onerous.
The classes in env.h were not adhering to the rule of five. As per the rule of five, if a class implements any of five special member functions, it must implement all the five special member functions for enabling the compiler for better optimization. Refs: https://en.cppreference.com/w/cpp/language/rule_of_three
Contributor
Author
|
@bnoordhuis I've made the changes that you requested. PTAL. |
Collaborator
joyeecheung
approved these changes
Jul 9, 2019
Trott
approved these changes
Jul 10, 2019
Member
|
Landed in 7e69bce |
Trott
pushed a commit
to Trott/io.js
that referenced
this pull request
Jul 10, 2019
The classes in env.h were not adhering to the rule of five. As per the rule of five, if a class implements any of five special member functions, it must implement all the five special member functions for enabling the compiler for better optimization. Refs: https://en.cppreference.com/w/cpp/language/rule_of_three PR-URL: nodejs#28579 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: Rich Trott <[email protected]>
targos
pushed a commit
that referenced
this pull request
Jul 20, 2019
The classes in env.h were not adhering to the rule of five. As per the rule of five, if a class implements any of five special member functions, it must implement all the five special member functions for enabling the compiler for better optimization. Refs: https://en.cppreference.com/w/cpp/language/rule_of_three PR-URL: #28579 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: Rich Trott <[email protected]>
This was referenced Jul 23, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Environment class was missing the move constructor
and the move assignmnet operator.
As per the rule of five, a class must implement all the
five special member functions in order to enable the
compiler for better optimization.
Refs: https://en.cppreference.com/w/cpp/language/rule_of_three
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes