Skip to content

src: use PauseOnNextJavascriptStatement to implement --inspect-brk-node #26034

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
joyeecheung wants to merge 2 commits into from
Closed

src: use PauseOnNextJavascriptStatement to implement --inspect-brk-node #26034

joyeecheung wants to merge 2 commits into from

Conversation

@joyeecheung
Copy link
Member

@joyeecheung joyeecheung commented Feb 10, 2019

Instead of using the debugger; statement which is visible in the
JS source code and makes primordials.js environment-dependent.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Feb 10, 2019

@joyeecheung build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/2564/pipeline

@nodejs-github-bot nodejs-github-bot added the c++ Issues and PRs that require attention from people who are familiar with C++. label Feb 10, 2019
@joyeecheung
Copy link
Member Author

joyeecheung commented Feb 12, 2019

CI: https://ci.nodejs.org/job/node-test-pull-request/20738/

@addaleax
Copy link
Member

addaleax commented Feb 13, 2019

@joyeecheung Looks like we need an #if HAVE_INSPECTOR here?

@joyeecheung
src: use PauseOnNextJavascriptStatement to implement --inspect-brk-node
f9741a0 
Instead of using the `debugger;` statement which is visible in the
JS source code and makes primordials.js environment-dependent.
@joyeecheung
fixup! src: use PauseOnNextJavascriptStatement to implement --inspect…
19bbf7f 
…-brk-node
@joyeecheung
Copy link
Member Author

joyeecheung commented Feb 17, 2019

Added #if HAVE_INSPECTOR for without-intl builds. CI: https://ci.nodejs.org/job/node-test-pull-request/20827/

@joyeecheung
Copy link
Member Author

joyeecheung commented Feb 18, 2019

Resume: https://ci.nodejs.org/job/node-test-pull-request/20855/

@danbev
Copy link
Contributor

danbev commented Feb 18, 2019

Landed in 45b7c98.

@danbev danbev closed this Feb 18, 2019
danbev pushed a commit that referenced this pull request Feb 18, 2019
@joyeecheung @danbev
src: use PauseOnNextJavascriptStatement to implement --inspect-brk-node
45b7c98 
Instead of using the `debugger;` statement which is visible in the
JS source code and makes primordials.js environment-dependent.

PR-URL: #26034
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Gus Caplan <[email protected]>
Reviewed-By: James M Snell <[email protected]>
addaleax pushed a commit that referenced this pull request Feb 18, 2019
@joyeecheung @addaleax
src: use PauseOnNextJavascriptStatement to implement --inspect-brk-node
7cf9930 
Instead of using the `debugger;` statement which is visible in the
JS source code and makes primordials.js environment-dependent.

PR-URL: #26034
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Gus Caplan <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@BridgeAR BridgeAR mentioned this pull request Feb 26, 2019
Merged
rvagg pushed a commit that referenced this pull request Feb 28, 2019
@joyeecheung @rvagg
src: use PauseOnNextJavascriptStatement to implement --inspect-brk-node
4ca0789 
Instead of using the `debugger;` statement which is visible in the
JS source code and makes primordials.js environment-dependent.

PR-URL: #26034
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Gus Caplan <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnell jasnell jasnell approved these changes

@addaleax addaleax addaleax approved these changes

@cjihrig cjihrig cjihrig approved these changes

+1 more reviewer

@devsnek devsnek devsnek approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

c++ Issues and PRs that require attention from people who are familiar with C++.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@joyeecheung @nodejs-github-bot @addaleax @danbev @jasnell @cjihrig @devsnek