Skip to content
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion .eslintignore
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,5 @@ lib/punycode.js
test/addons/doc-*/
test/fixtures
test/**/node_modules
test/parallel/test-fs-non-number-arguments-throw.js
test/disabled
test/tmp*/
33 changes: 20 additions & 13 deletions test/parallel/test-fs-non-number-arguments-throw.js
Original file line number Diff line number Diff line change
@@ -1,24 +1,31 @@
var assert = require('assert'),
fs = require('fs'),
saneEmitter,
sanity = 'ire(\'assert\')';
'use strict';

saneEmitter = fs.createReadStream(__filename, { start: 17, end: 29 });
const common = require('../common');
const assert = require('assert');
const fs = require('fs');
const path = require('path');
const tempFile = path.join(common.tmpDir, 'fs-non-number-arguments-throw');

assert.throws(function () {
fs.createReadStream(__filename, { start: "17", end: 29 });
common.refreshTmpDir();
fs.writeFileSync(tempFile, 'abc\ndef');

// a sanity check when using numbers instead of strings
const sanity = 'def';
const saneEmitter = fs.createReadStream(tempFile, { start: 4, end: 6 });

assert.throws(function() {
fs.createReadStream(tempFile, { start: '4', end: 6 });
}, "start as string didn't throw an error for createReadStream");

assert.throws(function () {
fs.createReadStream(__filename, { start: 17, end: "29" });
assert.throws(function() {
fs.createReadStream(tempFile, { start: 4, end: '6' });
}, "end as string didn't throw an error");

assert.throws(function () {
fs.createWriteStream(__filename, { start: "17" });
assert.throws(function() {
fs.createWriteStream(tempFile, { start: '4' });
}, "start as string didn't throw an error for createWriteStream");

saneEmitter.on('data', function (data) {
// a sanity check when using numbers instead of strings
saneEmitter.on('data', function(data) {
assert.strictEqual(sanity, data.toString('utf8'), 'read ' +
data.toString('utf8') + ' instead of ' + sanity);
});